You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/12/27 10:19:00 UTC
[GitHub] storm pull request #1843: Fix storm.py which breaks when client.jartransform...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1843
Fix storm.py which breaks when client.jartransformer.class is not set
When such configuration is not set, `confvalue` returns `nil` in 1.x branch, and `null` in master branch.
Such difference is based on whether language storm script runs:
- for 1.x, it runs `org.apache.storm.command.config_value` which is Clojure file
- for master, it runs `org.apache.storm.command.ConfigValue` which is Java file
I accidentally changed that value from `nil` to `null` without recognized the difference between master and 1.x.
Since it breaks all deployments on 1.x branch when client.jartransformer.class is not set, so it must be fixed before releasing.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm fix-storm-py-client-jar-transformer-is-not-set-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1843.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1843
----
commit fef1641ce5b30481ed30a52b730a1898ba33de09
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-12-27T10:04:48Z
Fix storm.py which breaks when client.jartransformer.class is not set
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1843: Fix storm.py which breaks when client.jartransformer.clas...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1843
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1843: Fix storm.py which breaks when client.jartransform...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1843
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---