You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by gn...@apache.org on 2023/04/13 09:35:08 UTC

[maven] branch master updated: Simplify logger creation leveraging Map.computeIfAbsent

This is an automated email from the ASF dual-hosted git repository.

gnodet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven.git


The following commit(s) were added to refs/heads/master by this push:
     new b7a3d8571 Simplify logger creation leveraging Map.computeIfAbsent
b7a3d8571 is described below

commit b7a3d857136ec89bdfe35aea05ed2746f09de162
Author: Guillaume Nodet <gn...@gmail.com>
AuthorDate: Thu Apr 6 15:52:12 2023 +0200

    Simplify logger creation leveraging Map.computeIfAbsent
---
 .../src/main/java/org/slf4j/impl/MavenLoggerFactory.java         | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java
index d37bac17d..16cf4d9ec 100644
--- a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java
+++ b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenLoggerFactory.java
@@ -49,14 +49,7 @@ public class MavenLoggerFactory extends SimpleLoggerFactory implements MavenSlf4
      */
     @Override
     public Logger getLogger(String name) {
-        Logger simpleLogger = loggerMap.get(name);
-        if (simpleLogger != null) {
-            return simpleLogger;
-        } else {
-            Logger newInstance = getNewLoggingInstance(name);
-            Logger oldInstance = loggerMap.putIfAbsent(name, newInstance);
-            return oldInstance == null ? newInstance : oldInstance;
-        }
+        return loggerMap.computeIfAbsent(name, this::getNewLoggingInstance);
     }
 
     private Logger getNewLoggingInstance(String name) {