You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/05/21 15:02:55 UTC

Review Request: CS-2273: Automation: Change account membership for VMs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Description
-------

Testcases for changing account membership for vas


Diffs
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Likitha Shetty <li...@citrix.com>.

> On May 23, 2013, 6:14 a.m., Likitha Shetty wrote:
> >

Ashutosh, are you referring to TP 8 in the Test-Plan? If yes, then the TP is still valid because in the TP the sub-domains (SubDomain1 and SubDomain2) that we are trying to move the VM’s between are under the same domain(Doamin1).
But from what I can see, in case of this test condition the sub-domains(subdomain1 and subdomain2) that we are trying to move the VM’s between are under two different domains. Is that right?

If we are trying to test TP 8 in this test then we can change line 155 from cls.sdomain_account_user2  = create_domain_account_user(cls.domain_account_user2['domain']) to cls.sdomain_account_user2  = create_domain_account_user(cls.domain_account_user1['domain']). With that change the test condition can pass the VM move.


- Likitha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review20929
-----------------------------------------------------------


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.

> On May 23, 2013, 6:14 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 321
> > <https://reviews.apache.org/r/11307/diff/3/?file=295683#file295683line321>
> >
> >     If a domain admin tries to move a VM to an account in a subdomain that belongs to a different domain, the request should fail. This is because a domain admin can only move VM's between 2 accounts that are in the domain path.
> >     So shouldn't the check condition of test_08 be changed?

As per https://cwiki.apache.org/confluence/display/CLOUDSTACK/Change+account+membership+Test+Plan this test condition should pass the vm move.

Shall i change the TP and test check condition? 


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review20929
-----------------------------------------------------------


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review20929
-----------------------------------------------------------



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43114>

    If a domain admin tries to move a VM to an account in a subdomain that belongs to a different domain, the request should fail. This is because a domain admin can only move VM's between 2 accounts that are in the domain path.
    So shouldn't the check condition of test_08 be changed?


- Likitha Shetty


On May 23, 2013, 3:56 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 3:56 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.

> On May 28, 2013, 9:58 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 382
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line382>
> >
> >     Even the root disk snapshots are deleted.
> >     And since the VM will be successfully moved if both the domains are under the same domain admin shouldn't the test condition change?

Yes as root disk snapshots are also deleted. I have added assert for snapshot check and removed the assertRaise


> On May 28, 2013, 9:58 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 404
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line404>
> >
> >     Oh that makes sense.
> >     
> >     If the resource type is snapshot shouldn't the value of resourceType parameter be '3' for updateResourceLimit API?
> >     I am a little confused. So the test case is that we reduce the snapshot resource limit of subdomain2 to 1 and try to move a VM with 1 snapshot to subdomain1?

Right, but now since as you have mentioned both ROOT and DATA_DISKS snapshots are deleted once VM owner is changed, this limit condition will not work.
I have updated the test to check for number of instances and max instance is set to 0.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21084
-----------------------------------------------------------


On May 28, 2013, 9:45 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 9:45 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21084
-----------------------------------------------------------



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43623>

    Got it, thanks



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43622>

    All snapshots(of both root and attached volumes)are deleted. And the since the VM will be successfully moved shouldn't test condition be different? 



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43624>

    Even the root disk snapshots are deleted.
    And since the VM will be successfully moved if both the domains are under the same domain admin shouldn't the test condition change?



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43627>

    Oh that makes sense.
    
    If the resource type is snapshot shouldn't the value of resourceType parameter be '3' for updateResourceLimit API?
    I am a little confused. So the test case is that we reduce the snapshot resource limit of subdomain2 to 1 and try to move a VM with 1 snapshot to subdomain1?  


- Likitha Shetty


On May 28, 2013, 9:45 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 9:45 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21177
-----------------------------------------------------------

Ship it!


Shipped with 85062a75ae363ec37d00cd1beb92a29b408cd238

- Prasanna Santhanam


On May 28, 2013, 10:22 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 10:22 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 28, 2013, 10:22 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.


Changes
-------

review changes: 1) Check snapshots are deleted when vm ownership is changed. 2) limit resource check on vm instances for target account.


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs (updated)
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 28, 2013, 9:45 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.


Changes
-------

Review changes: check for volume owner domain and default network in target domain 


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs (updated)
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 28, 2013, 8:28 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.


Changes
-------

including QA owner of the test plan


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21081
-----------------------------------------------------------


First two comments have been repeated, please ignore the duplicates.

- Likitha Shetty


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.

> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 360
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line360>
> >
> >     create_vm with pf=true has been implemented?

Yes, VirtualMachine.create() checks for mode if mode is 'advance' it crate pf rule else it does not. 


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 370
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line370>
> >
> >     If a VM with attached volumes is moved then the VM along with the volumes will be successfully moved to the new owner.

Sure I will add check for volume


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 382
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line382>
> >
> >     When a VM is moved the snapshots of the attached volumes is deleted and the move is successful.

In this test case we are testing for VM ownership change for VM with root disk snapshot not volumes are attached.


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 322
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line322>
> >
> >     How is this test different from test_07?

Yes target account should not have any default network and network should get crated once vm ownership is changed, I need to add assert for network created in target account.


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 404
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line404>
> >
> >     In this test case we are setting the limit on the number of VM's that can be in subdomain1 to 1.
> >     Haven't we already moved a number of VMs to subdomain1 that are yet to cleaned up?

for a test run only 1 vm is created and destroyed after test run is complete not test suite.  limit resource type is snapshot


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 424
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line424>
> >
> >     Same concern as above.
> >     Also, can you specify for what resource the account limit has been reached? If it is VM how is it different from test_16?

for this test run limit resource type is snapshot. pre conditions are volumes attached to a vm and limit is reached.


> On May 28, 2013, 8:22 a.m., Likitha Shetty wrote:
> > test/integration/component/test_assign_vm.py, line 322
> > <https://reviews.apache.org/r/11307/diff/4/?file=297101#file297101line322>
> >
> >     How is this test case different from test_07

here we only check for vm ownership change.


- Ashutosh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21077
-----------------------------------------------------------


On May 28, 2013, 8:28 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 8:28 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, Parth Jagirdar, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/#review21077
-----------------------------------------------------------



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43587>

    How is this test case different from test_07



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43589>

    How is this test different from test_07?



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43591>

    create_vm with pf=true has been implemented?



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43588>

    create_vm with pf=true has been implemented?



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43594>

    If a VM with attached volumes is moved then the VM along with the volumes will be successfully moved to the new owner.



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43596>

    When a VM is moved the snapshots of the attached volumes is deleted and the move is successful.



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43597>

    In this test case we are setting the limit on the number of VM's that can be in subdomain1 to 1.
    Haven't we already moved a number of VMs to subdomain1 that are yet to cleaned up?



test/integration/component/test_assign_vm.py
<https://reviews.apache.org/r/11307/#comment43607>

    Same concern as above.
    Also, can you specify for what resource the account limit has been reached? If it is VM how is it different from test_16?


- Likitha Shetty


On May 28, 2013, 5:29 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11307/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 5:29 a.m.)
> 
> 
> Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Testcases for changing account membership for vas
> 
> 
> This addresses bug CLOUDSTACK-2273.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_assign_vm.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py f3a96bd 
> 
> Diff: https://reviews.apache.org/r/11307/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 28, 2013, 5:29 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.


Changes
-------

Added few more tests related to limits, projects and snapshots


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs (updated)
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 23, 2013, 3:56 a.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.


Changes
-------

updated patch set for vm create without pf rule


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs (updated)
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 21, 2013, 3 p.m.)


Review request for cloudstack, Likitha Shetty, Prasanna Santhanam, and Girish Shilamkar.


Changes
-------

Including feature dev as reviewer


Description
-------

Testcases for changing account membership for vas


This addresses bug CLOUDSTACK-2273.


Diffs
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar


Re: Review Request: CS-2273: Automation: Change account membership for VMs

Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11307/
-----------------------------------------------------------

(Updated May 21, 2013, 1:18 p.m.)


Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.


Changes
-------

Updated the patch


Description
-------

Testcases for changing account membership for vas


Diffs (updated)
-----

  test/integration/component/test_assign_vm.py PRE-CREATION 
  tools/marvin/marvin/integration/lib/base.py f3a96bd 

Diff: https://reviews.apache.org/r/11307/diff/


Testing
-------


Thanks,

Ashutosh Kelkar