You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/06/25 03:55:53 UTC

[GitHub] [incubator-kvrocks] Xuanwo opened a new pull request, #667: ci: Cancel previous workflows on the same ref

Xuanwo opened a new pull request, #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667

   Cancel previous workflows if they are the same workflow on the same ref (branch/tags)
   with the same event (push/pull_request) even if they are in progress.
   This setting will help reduce the number of duplicated workflows.
   
   Signed-off-by: Xuanwo <gi...@xuanwo.io>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] Xuanwo commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
Xuanwo commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166187797

   Oh, my IDE cleaned all space in workflow files too. Although they are not intended to be changed in this PR but seem cool?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
git-hulk commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166190090

   I think remove those unintended spaces is good even didn't relate to current topic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] Xuanwo commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
Xuanwo commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166192430

   > Is there a way to exclude manually retried workflows?
   > I think the user might not want to pause the current workflow while retrying some workflow.
   
   Github doesn't support retry workflow (entirely or partly) without canceling the current workflow.
   
   I guess what you mean is retry some jobs in the workflow. Retry failed jobs will work as expected without breaking already succeeded jobs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166193899

   > It doesn't make sense to me to retry a previous workflow after new commits have been pushed. Canceling them is a good choice for me.
   
   Yeah, I agree that **in most cases** just running the last commit is good.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] Xuanwo commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
Xuanwo commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166193320

   > * commit 1 first ci run failed, manual retry running
   > * commit 2 running
   
   It doesn't make sense to me to retry a previous workflow after new commits have been pushed. Canceling them is a good choice for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] tisonkun merged pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #667: ci: Cancel previous workflows on the same ref

Posted by GitBox <gi...@apache.org>.
PragmaTwice commented on PR #667:
URL: https://github.com/apache/incubator-kvrocks/pull/667#issuecomment-1166193005

   > 
   
   Thanks. Actually what I want to say is a special case:
   
   In PR a:
   - commit 1 first ci run failed, manual retry running
   - commit 2 running
   
   But I think maybe this is very rare, so it is not something this PR needs to consider.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org