You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/04 22:20:15 UTC

[GitHub] GabeLoins commented on issue #4909: [Explore] Adding Adhoc Filters

GabeLoins commented on issue #4909: [Explore] Adding Adhoc Filters
URL: https://github.com/apache/incubator-superset/pull/4909#issuecomment-386749668
 
 
   Made a couple of aesthetic changes based on feedback from the team
   
   Pills now appear darker and more clickable:
   ![image](https://user-images.githubusercontent.com/2455694/39655402-477b896c-4fae-11e8-9bfc-4d394feb1ff5.png)
   
   the text area is also wrapped in a thin border (and by wraps overflow text to new lines rather than hiding it):
   
   ![image](https://user-images.githubusercontent.com/2455694/39655425-5beab3c8-4fae-11e8-8756-ad2b2d65865e.png)
   
   I also introduced some ways to give feedback that simple filters cannot filter on metrics in table datasources:
   ![image](https://user-images.githubusercontent.com/2455694/39655468-99b00ba4-4fae-11e8-9239-f5e17cabe462.png)
   
   ![image](https://user-images.githubusercontent.com/2455694/39655469-9f3eb142-4fae-11e8-9bb6-334371fb8c03.png)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org