You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/12 09:06:52 UTC
[GitHub] [arrow] raulcd opened a new pull request, #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
raulcd opened a new pull request, #12862:
URL: https://github.com/apache/arrow/pull/12862
This PR fixes the current issue with our nightly reports as seen here: https://github.com/ursacomputing/crossbow/runs/5840285120?check_suite_focus=true)
The issue could be reproduced using the prefix that crossbow reports uses:
```
job_prefix=nightly-${{ inputs.report_type }}-$(date -I)
job_id=$(archery crossbow latest-prefix ${job_prefix})
```
Before the fix, when using the following query:
```
$ archery crossbow latest-prefix --no-fetch nightly-packaging-2022-04-10
Traceback (most recent call last):
File "/home/raulcd/open_source/pyarrow-dev/bin/archery", line 33, in <module>
sys.exit(load_entry_point('archery', 'console_scripts', 'archery')())
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
return self.main(*args, **kwargs)
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1055, in main
rv = self.invoke(ctx)
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/core.py", line 760, in invoke
return __callback(*args, **kwargs)
File "/home/raulcd/open_source/pyarrow-dev/lib/python3.10/site-packages/click/decorators.py", line 38, in new_func
return f(get_current_context().obj, *args, **kwargs)
File "/home/raulcd/open_source/arrow/dev/archery/archery/crossbow/cli.py", line 237, in latest_prefix
latest = queue.latest_for_prefix(prefix)
File "/home/raulcd/open_source/arrow/dev/archery/archery/crossbow/core.py", line 568, in latest_for_prefix
latest_id += "-0"
TypeError: unsupported operand type(s) for +=: 'int' and 'str'
```
After the fix:
```
$ archery crossbow latest-prefix --no-fetch nightly-packaging-2022-04-10
nightly-packaging-2022-04-10-0
$ archery crossbow latest-prefix --no-fetch nightly-packaging
nightly-packaging-2022-04-11-0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
URL: https://github.com/apache/arrow/pull/12862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12862:
URL: https://github.com/apache/arrow/pull/12862#issuecomment-1097009877
Benchmark runs are scheduled for baseline = 7d4e93dafdd96c6540d822851ee3ccd10e167a4f and contender = 8f5936f4bc5b02b3b3516831bbde23b55c213249. 8f5936f4bc5b02b3b3516831bbde23b55c213249 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f467a8fdbf7a4bf9b88a3e2fe3f99d1b...22009ad831f54d0a9bf541f8ac12ab19/)
[Failed :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/98f41235bcb1446f92180cb46c281a27...6baf96e7f4a84dfc80d1ccd99b9cf2a3/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7127f6a45d4443b481b02e6d9174f03f...0c379c83d35947f2a9530bee5fa0651b/)
[Finished :arrow_down:0.3% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d5b4709cc9aa4930a5fa2500516007c1...b3f001995c08477c9092babb6ecef5f6/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/489| `8f5936f4` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/474| `8f5936f4` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/475| `8f5936f4` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/484| `8f5936f4` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/488| `7d4e93da` ec2-t3-xlarge-us-east-2>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/473| `7d4e93da` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/474| `7d4e93da` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/483| `7d4e93da` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
Posted by GitBox <gi...@apache.org>.
raulcd commented on PR #12862:
URL: https://github.com/apache/arrow/pull/12862#issuecomment-1096817861
> Thanks for this! The change itself looks good. I know there aren't existing tests for this in https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/tests/test_core.py (or elsewhere), but it would be good for us to add them as we make additions like this so that we can see what behavior we're expecting | what might break this. Would you mind adding a handful of tests (at least the ones you have in the PR comment...)?
I've added the requested test that covers the usage scenarios on my comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12862:
URL: https://github.com/apache/arrow/pull/12862#issuecomment-1096409823
https://issues.apache.org/jira/browse/ARROW-16165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on pull request #12862: ARROW-16165: [CI][Archery] Fix nightly query to crossbow to send reports
Posted by GitBox <gi...@apache.org>.
jonkeane commented on PR #12862:
URL: https://github.com/apache/arrow/pull/12862#issuecomment-1096697300
Thanks for this! The change itself looks good. I know there aren't existing tests for this in https://github.com/apache/arrow/blob/master/dev/archery/archery/crossbow/tests/test_core.py (or elsewhere), but it would be good for us to add them as we make additions like this so that we can see what behavior we're expecting | what might break this. Would you mind adding a handful of tests (at least the ones you have in the PR comment...)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org