You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/14 04:13:49 UTC
[GitHub] [spark] cloud-fan commented on a diff in pull request #38631: [SPARK-40809] [CONNECT] [FOLLOW] Support `alias()` in Python client
cloud-fan commented on code in PR #38631:
URL: https://github.com/apache/spark/pull/38631#discussion_r1021059774
##########
connector/connect/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -170,6 +170,8 @@ message Expression {
message Alias {
Expression expr = 1;
- string name = 2;
+ repeated string name = 2;
Review Comment:
In catalyst, we have a `MultiAlias` expression for this case. Shall we match catalyst here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org