You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@activemq.apache.org by "Justin Bertram (Jira)" <ji...@apache.org> on 2020/01/22 21:34:01 UTC

[jira] [Resolved] (ARTEMIS-2571) Remove unneccessary synchronization in ActiveMQServerImpl

     [ https://issues.apache.org/jira/browse/ARTEMIS-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Justin Bertram resolved ARTEMIS-2571.
-------------------------------------
    Fix Version/s: 2.12.0
       Resolution: Fixed

> Remove unneccessary synchronization in ActiveMQServerImpl
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-2571
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2571
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker, Web Console
>    Affects Versions: 2.10.1
>            Reporter: Sebastian T
>            Priority: Minor
>             Fix For: 2.12.0
>
>         Attachments: artemis-test.zip
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> The ActiveMQServerImpl sessions field is a ConcurrentHashMap. Synchronizing on the ActiveMQServerImpl object to iterate over the map is not necessary. ActiveMQServerImpl#getSession, ActiveMQServerImpl#removeSession and ActiveMQServerImpl#createSession also work on the sessions field without synchronizing on the ActiveMQServerImpl.
> Removing the synchronized keyword on the ActiveMQServerImpl#getSessions() methods e.g. improves loading of Connections view, especially when multiple administrators are using the UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)