[GitHub] [superset] villebro commented on a diff in pull request #23981: chore: Deprecate DND feature flags

["villebro (via GitHub)" <gi...@apache.org>]

villebro commented on code in PR #23981:
URL: https://github.com/apache/superset/pull/23981#discussion_r1189734141


##########
superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx:
##########
@@ -244,8 +244,7 @@ export const dndGranularitySqlaControl: typeof dndSeriesControl = {
   default: (c: Control) => c.default,
   clearable: false,
   canDelete: false,
-  ghostButtonText: t('Drop temporal column here'),
-  clickEnabledGhostButtonText: t('Drop a temporal column here or click'),
+  ghostButtonText: t('Drop temporal column here or click'),

Review Comment:
   Was leaving the "a" out intentional? I'm ok both ways but if we change the string existing translations will break.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org