You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/07/31 17:54:09 UTC
[GitHub] flink pull request #4438: [FLINK-7324] [futures] Replace Flink's future with...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4438
[FLINK-7324] [futures] Replace Flink's future with Java 8's CompletableFuture in SlotPool
## What is the purpose of the change
Replace Flink's future with Java 8's CompletableFuture in SlotPool.
This PR is based on #4429.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink rfSlotPool
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4438.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4438
----
commit afe1d171132bb3724e672a1c4ce74a3f7c185908
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-31T13:07:18Z
[FLINK-7313] [futures] Add Flink future and Scala future to Java 8 CompletableFuture conversion
Add DirectExecutionContext
Add Scala Future to Java 8 CompletableFuture utility to FutureUtils
Add Flink future to Java 8's CompletableFuture conversion utility to FutureUtils
Add base class for Flink's unchecked future exceptions
commit c265fa386184b1fb940187c7f97c14e1542509de
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-07-31T17:35:14Z
[FLINK-7324] [futures] Replace Flink's future with Java 8's CompletableFuture in SlotPool
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4438: [FLINK-7324] [futures] Replace Flink's future with Java 8...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4438
Thanks for the review @zentol. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4438: [FLINK-7324] [futures] Replace Flink's future with...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4438#discussion_r130429317
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java ---
@@ -344,4 +344,26 @@ public void onComplete(Throwable failure, T success) throws Throwable {
return result;
}
+
+ /**
+ * Converts a Java 8 {@link java.util.concurrent.CompletableFuture} into a Flink {@link Future}.
+ *
+ * @param javaFuture to convert to a Flink future
+ * @param <T> type of the future value
+ * @return Flink future
+ */
+ public static <T> Future<T> toFlinkFuture(java.util.concurrent.CompletableFuture<T> javaFuture) {
--- End diff --
Add deprecated annotation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4438: [FLINK-7324] [futures] Replace Flink's future with...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4438
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4438: [FLINK-7324] [futures] Replace Flink's future with...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4438#discussion_r130589358
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java ---
@@ -344,4 +344,26 @@ public void onComplete(Throwable failure, T success) throws Throwable {
return result;
}
+
+ /**
+ * Converts a Java 8 {@link java.util.concurrent.CompletableFuture} into a Flink {@link Future}.
+ *
+ * @param javaFuture to convert to a Flink future
+ * @param <T> type of the future value
+ * @return Flink future
+ */
+ public static <T> Future<T> toFlinkFuture(java.util.concurrent.CompletableFuture<T> javaFuture) {
--- End diff --
Good point. Will add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---