You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "gertwieland (via GitHub)" <gi...@apache.org> on 2023/08/12 21:28:33 UTC
[I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
gertwieland opened a new issue, #3157:
URL: https://github.com/apache/hop/issues/3157
### Apache Hop version?
2.5
### Java version?
openjdk 11.0.19 2023-04-18 OpenJDK Runtime Environment OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u) OpenJDK 64-Bit Server VM OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u, mixed mode)
### Operating system
Windows
### What happened?
In the "Stream Lookup" field, I would expect the "Get Lookup fields" to pull the "Lookup fields", but it doesn't. Instead, it pulls the "Fields to retrieve".
But the "Get Fields" button pulls the "Lookup fields".
I think this should be the opposite.
<img width="680" alt="image" src="https://github.com/apache/hop/assets/51762835/7c2201b7-986c-4818-974d-175374e1ffcb">
### Issue Priority
Priority: 3
### Issue Component
Component: Hop Gui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-1691575840
I agree that the naming is confusing.
what do you think about the following:
Get fields -> Get return fields
Get lookup fields -> get lookup key fields
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-2093364133
It's a little clearer this way ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "harrisward (via GitHub)" <gi...@apache.org>.
harrisward commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-1691477883
I think its right but a little confusion as the Get Lookup Fields Means "Get the fields to lookup from the Lookup Transform". Maybe the names of the buttons could be a bit better? Like "Get Key Fields" for the look up values and "Get Lookup Fields" for the fields to return to the primary transform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-2097726176
Has been aligned:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-1691576097
.take-issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "gertwieland (via GitHub)" <gi...@apache.org>.
gertwieland commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-1692520357
I think the "Get **lookup fields**" should refer to the "**LookupField**" column in the upper part.
Then, in the lower part, it reads "Specify **fields to retrieve**". Maybe the button could just say "Get **retrieve fields**"?
My idea is that this way the headers matches the text on the buttons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-2087610834
My proposal:
Get fields -> Get key fields
Get lookup fields -> Get fields to retrieve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "usbrandon (via GitHub)" <gi...@apache.org>.
usbrandon commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-2093968451
"Get key fields" and "Get return fields". I would just make the case match, but it is much clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "usbrandon (via GitHub)" <gi...@apache.org>.
usbrandon commented on issue #3157:
URL: https://github.com/apache/hop/issues/3157#issuecomment-2092008710
I agree with that and also adding the word 'key' "Get key fields" to let it contextualize what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva closed issue #3157: [Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped
URL: https://github.com/apache/hop/issues/3157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org