[GitHub] trafficserver pull request #753: TS-4705: Proposal: NetVC Context

[jpeach <gi...@git.apache.org>]

Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/753#discussion_r77095956
  
    --- Diff: iocore/net/I_NetVConnection.h ---
    @@ -566,6 +573,21 @@ class NetVConnection : public VConnection
         is_transparent = state;
       }
     
    +  /// Set the context and return context value
    +  NetVConnectionContext_t
    +  set_context(NetVConnectionContext_t context)
    --- End diff --
    
    The return value of this is never used, so can we remove it? If the expectation is that the context is only set once, can we either
        - do it in the constructor and remove this
        - assert that it is unset here.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---