You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/09/21 16:07:45 UTC
[GitHub] [netbeans] troizet opened a new pull request, #4670: PHP: Fixed a NPE from issue #4629
troizet opened a new pull request, #4670:
URL: https://github.com/apache/netbeans/pull/4670
Hello! This PR fixes the NPE error that occurs when you change the existing visibility declaration of a class property or method when you press Enter or click it in the autocomplete list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4670: Fixed a NPE from issue #4629
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4670:
URL: https://github.com/apache/netbeans/pull/4670#discussion_r977884729
##########
ide/editor.codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateInsertHandler.java:
##########
@@ -515,7 +515,7 @@ private static boolean shouldOpenCompletionAfter(TextRegionManagerEvent evt) {
return false;
}
TextSync last = removed.get(removed.size()-1).activeTextSync();
- return last.isCaretMarker() && last.isCompletionInvoke();
+ return (last != null && last.isCaretMarker() && last.isCompletionInvoke());
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #4670: Fixed a NPE from issue #4629
Posted by GitBox <gi...@apache.org>.
mbien merged PR #4670:
URL: https://github.com/apache/netbeans/pull/4670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] troizet commented on a diff in pull request #4670: Fixed a NPE from issue #4629
Posted by GitBox <gi...@apache.org>.
troizet commented on code in PR #4670:
URL: https://github.com/apache/netbeans/pull/4670#discussion_r977828550
##########
ide/editor.codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateInsertHandler.java:
##########
@@ -515,7 +515,7 @@ private static boolean shouldOpenCompletionAfter(TextRegionManagerEvent evt) {
return false;
}
TextSync last = removed.get(removed.size()-1).activeTextSync();
- return last.isCaretMarker() && last.isCompletionInvoke();
+ return (last != null && last.isCaretMarker() && last.isCompletionInvoke());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a diff in pull request #4670: Fixed a NPE from issue #4629
Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4670:
URL: https://github.com/apache/netbeans/pull/4670#discussion_r977205830
##########
ide/editor.codetemplates/src/org/netbeans/lib/editor/codetemplates/CodeTemplateInsertHandler.java:
##########
@@ -515,7 +515,7 @@ private static boolean shouldOpenCompletionAfter(TextRegionManagerEvent evt) {
return false;
}
TextSync last = removed.get(removed.size()-1).activeTextSync();
- return last.isCaretMarker() && last.isCompletionInvoke();
+ return (last != null && last.isCaretMarker() && last.isCompletionInvoke());
Review Comment:
nitpick: would you mind removing the outer braces (....)? I don't think it is helping with readability here ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists