[GitHub] [poi] pjfanning commented on a change in pull request #310: Allow sections to have distinct headers and footers

[GitBox <gi...@apache.org>]

pjfanning commented on a change in pull request #310:
URL: https://github.com/apache/poi/pull/310#discussion_r820119473



##########
File path: poi-ooxml/src/main/java/org/apache/poi/xwpf/model/XWPFHeaderFooterPolicy.java
##########
@@ -52,227 +41,236 @@ Licensed to the Apache Software Foundation (ASF) under one or more
 import org.openxmlformats.schemas.wordprocessingml.x2006.main.STHdrFtr;
 import org.openxmlformats.schemas.wordprocessingml.x2006.main.STHdrFtr.Enum;
 
+import com.microsoft.schemas.office.office.CTLock;
+import com.microsoft.schemas.office.office.STConnectType;
+import com.microsoft.schemas.vml.CTFormulas;
+import com.microsoft.schemas.vml.CTGroup;
+import com.microsoft.schemas.vml.CTH;
+import com.microsoft.schemas.vml.CTHandles;
+import com.microsoft.schemas.vml.CTPath;
+import com.microsoft.schemas.vml.CTShape;
+import com.microsoft.schemas.vml.CTShapetype;
+import com.microsoft.schemas.vml.CTTextPath;
+import com.microsoft.schemas.vml.STExt;
+
 /**
- * A .docx file can have no headers/footers, the same header/footer
- * on each page, odd/even page footers, and optionally also
- * a different header/footer on the first page.
- * This class handles sorting out what there is, and giving you
+ * A .docx file can have no headers/footers, the same header/footer on each
+ * page, odd/even page footers, and optionally also a different header/footer on
+ * the first page. This class handles sorting out what there is, and giving you
  * the right headers and footers for the document.
  */
 public class XWPFHeaderFooterPolicy {
-    public static final Enum DEFAULT = STHdrFtr.DEFAULT;
-    public static final Enum EVEN = STHdrFtr.EVEN;
-    public static final Enum FIRST = STHdrFtr.FIRST;
-
-    private XWPFDocument doc;
-
-    private XWPFHeader firstPageHeader;

Review comment:
       please do not reformat the file - use the existing format so the changes can be evaluated - we use spaces for indents - not tabs.
   
   Leave the imports in the same order
   
   Don't reformat the existing javadocs




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org