You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@felix.apache.org by pd...@apache.org on 2014/10/27 18:53:15 UTC
svn commit: r1634623 - in /felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm: context/AbstractDependency.java impl/ComponentImpl.java

Author: pderop
Date: Mon Oct 27 17:53:15 2014
New Revision: 1634623

URL: http://svn.apache.org/r1634623
Log:
FELIX-3914: Log unsuccessful field injections using ERROR log level.

Modified:
    felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/context/AbstractDependency.java
    felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java

Modified: felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/context/AbstractDependency.java
URL: http://svn.apache.org/viewvc/felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/context/AbstractDependency.java?rev=1634623&r1=1634622&r2=1634623&view=diff
==============================================================================
--- felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/context/AbstractDependency.java (original)
+++ felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/context/AbstractDependency.java Mon Oct 27 17:53:15 2014
@@ -438,10 +438,10 @@ public abstract class AbstractDependency
     
     private void callbackNotFound(String callback) {
         if (m_logger == null) {
-        System.out.println("Dependency \"" + callback + "\" callback not found on componnent instances "
-            + Arrays.toString(m_component.getInstances()));
+            System.out.println("Dependency \"" + callback + "\" callback not found on componnent instances "
+                + Arrays.toString(m_component.getInstances()));
         } else {
-            m_logger.log(LogService.LOG_WARNING, "Dependency \"" + callback + "\" callback not found on componnent instances "
+            m_logger.log(LogService.LOG_ERROR, "Dependency \"" + callback + "\" callback not found on componnent instances "
                 + Arrays.toString(m_component.getInstances()));
         }
     }

Modified: felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java
URL: http://svn.apache.org/viewvc/felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java?rev=1634623&r1=1634622&r2=1634623&view=diff
==============================================================================
--- felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java (original)
+++ felix/sandbox/pderop/dependencymanager-prototype/org.apache.felix.dependencymanager/src/org/apache/felix/dm/impl/ComponentImpl.java Mon Oct 27 17:53:15 2014
@@ -947,7 +947,7 @@ public class ComponentImpl implements Co
             // If the target is an abstract decorator (i.e: an adapter, or an aspect), we must not log warnings
             // if field has not been injected.
             if (! (getInstance() instanceof AbstractDecorator)) {
-                m_logger.log(Logger.LOG_WARNING, "Could not inject " + instance + " to field \"" + fieldName
+                m_logger.log(Logger.LOG_ERROR, "Could not inject " + instance + " to field \"" + fieldName
                     + "\" at any of the following component instances: " + Arrays.toString(targets));
             }
         }
@@ -959,7 +959,7 @@ public class ComponentImpl implements Co
             // If the target is an abstract decorator (i.e: an adapter, or an aspect), we must not log warnings
             // if field has not been injected.
             if (! (getInstance() instanceof AbstractDecorator)) {
-                m_logger.log(Logger.LOG_WARNING, "Could not inject dependency " + clazz.getName() + " to field \""
+                m_logger.log(Logger.LOG_ERROR, "Could not inject dependency " + clazz.getName() + " to field \""
                     + fieldName + "\" at any of the following component instances: " + Arrays.toString(targets));
             }
         }