You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Matthew Topol (Jira)" <ji...@apache.org> on 2021/10/27 15:15:00 UTC

[jira] [Commented] (ARROW-8621) [Release][Go] Add Module support by creating tags

    [ https://issues.apache.org/jira/browse/ARROW-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17434905#comment-17434905 ] 

Matthew Topol commented on ARROW-8621:
--------------------------------------

So, it turns out that there's one more piece that needs to happen with the module tags. The go.mod and imports needs to updated to a corresponding major version sadly. Currently I get an error when i try to do `go get -u github.com/apache/arrow/go/arrow@v6.0.0` So i'll update the scripts accordingly. We'll probably need to either shift the go/arrow/v6.0.0 tags, or we'll need to release a version v6.0.1 after I make the update. 

[~kou] There exists a utility which can automate performing the update of the imports and go.mod files, but it requires having go installed to run. Is it okay to utilize that in the release scripts? Is there somewhere I should update to install Go or otherwise for the post-release tasks?

> [Release][Go] Add Module support by creating tags
> -------------------------------------------------
>
>                 Key: ARROW-8621
>                 URL: https://issues.apache.org/jira/browse/ARROW-8621
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Go
>            Reporter: Kyle Brandt
>            Assignee: Matthew Topol
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 6.0.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Arrow has a go.mod, but the go modules system expects a certain git tag for Go modules to work.
> Based on [https://github.com/golang/go/wiki/Modules#faqs--multi-module-repositories] I believe the tag would be 
> {code}
> go/arrow/v0.17.0
> {code}
> Currently:
> {code}
> $ go get github.com/apache/arrow/go/arrow@v0.17.0 
> go get github.com/apache/arrow/go/arrow@v0.17.0: github.com/apache/arrow/go/arrow@v0.17.0: invalid version: unknown revision go/arrow/v0.17.0
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)