You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@avro.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/01/30 20:27:00 UTC

[jira] [Commented] (AVRO-3324) Add omitted braces in AvroDecimal

    [ https://issues.apache.org/jira/browse/AVRO-3324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484443#comment-17484443 ] 

ASF subversion and git services commented on AVRO-3324:
-------------------------------------------------------

Commit f7188bed2888d72a91c27e3ff0e7da63fe4ecc35 in avro's branch refs/heads/master from Kyle Schoonover
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=f7188be ]

AVRO-3324 Styling - Added braces for if statements (#1475)

Co-authored-by: Kyle T. Schoonover <Ky...@nordstrom.com>

> Add omitted braces in AvroDecimal
> ---------------------------------
>
>                 Key: AVRO-3324
>                 URL: https://issues.apache.org/jira/browse/AVRO-3324
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.0
>            Reporter: Kyle Schoonover
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Styling improvement.  It is standard that when there is an if statement that the following line of code is executed.  However this can cause confusion when maintaining a code base.  This would require all statements with optional braces to include the braces.
>  
> Style Rule Reference: [StyleCopAnalyzers/SA1503.md at master · DotNetAnalyzers/StyleCopAnalyzers (github.com)|https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1503.md]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)