[GitHub] szha opened a new pull request #9394: text api changes

[GitBox <gi...@apache.org>]

szha opened a new pull request #9394: text api changes
URL: https://github.com/apache/incubator-mxnet/pull/9394
 
 
   ## Description ##
   host embeddings from s3. fixes.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Passed code style checking (`make lint`)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [x] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [x] Serve embedding files from apache-mxnet s3 bucket backed by CDN. Include licenses in doc.
   - [x] Refactor download logic. Reuse mxnet repo logic from other modules.
   - [x] Check existing embedding files for hash match and skip download if matched
   - [x] Update embedding parsing to be line-by-line to reduce peak memory usage.
   - [x] Update test for downloadable embedding to not rely on 800mb file, and use relative path instead of default user path in tests.
   
   ## Comments ##
   - No API change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services