[GitHub] [spark] kazuyukitanimura commented on a diff in pull request #36067: [SPARK-38573][SQL] Support Auto Partition Level Statistics Collection

[GitBox <gi...@apache.org>]

kazuyukitanimura commented on code in PR #36067:
URL: https://github.com/apache/spark/pull/36067#discussion_r842249148


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala:
##########
@@ -62,6 +66,14 @@ object CommandUtils extends Logging {
       if (isNewStats) {
         val newStats = CatalogStatistics(sizeInBytes = newSize)
         catalog.alterTableStats(table.identifier, Some(newStats))
+
+        if (withAutoPartitionStats) {
+          if (partitionSpec.nonEmpty) {
+            AnalyzePartitionCommand(table.identifier, partitionSpec, false).run(sparkSession)
+          } else if (table.partitionColumnNames.nonEmpty) {
+            AnalyzePartitionCommand(table.identifier, partitionSpec, false).run(sparkSession)

Review Comment:
   Right. Would you recommend to make a new config to enable/disable full scan?
   
   The doc says `spark.sql.statistics.size.autoUpdate.enabled` can be expensive anyway, so I chose to do full can always for the first review...
   https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala#L2323



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org