You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dahhs (via GitHub)" <gi...@apache.org> on 2026/10/15 10:07:12 UTC
[PR] [SPARK-60257][SDP][TEST] Test pipeline event responses missing result fields [spark]
dahhs opened a new pull request, #59504:
URL: https://github.com/apache/spark/pull/59504
### What changes were proposed in this pull request?
Add a unit test to `python/pyspark/pipelines/tests/test_spark_connect.py` verifying that `handle_pipeline_events()` raises `PySparkValueError` when a dictionary response contains neither `pipeline_command_result` nor `pipeline_event_result`.
### Why are the changes needed?
Existing tests cover unsupported response types but not dictionary responses containing neither `pipeline_command_result` nor `pipeline_event_result`.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Added a unit test verifying that `handle_pipeline_events()` rejects dictionary responses missing pipeline result fields.
Ran the test suite successfully:
```bash
python/run-tests \
--python-executables=python \
--testnames pyspark.pipelines.tests.test_spark_connect
```
Ran the suite with coverage and confirmed that the missing-result error branch is covered:
```bash
python/run-tests-with-coverage \
--python-executables=python \
--testnames pyspark.pipelines.tests.test_spark_connect
```
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (6.1 Sol), used as a pair-programming assistant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60257][SDP][TEST] Test pipeline event responses missing result fields [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #59504:
URL: https://github.com/apache/spark/pull/59504#issuecomment-6289214755
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/7f377718d87cd39f33af9faa4dd0b1b7c7119fd2
- merged into branch-4.x https://github.com/apache/spark/commit/e544c0c119874f87c9e3b87eccac12775ac60f27
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60257][SDP][TEST] Test pipeline event responses missing result fields [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #59504: [SPARK-60257][SDP][TEST] Test pipeline event responses missing result fields
URL: https://github.com/apache/spark/pull/59504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org