You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <p....@ubik-ingenierie.com> on 2017/01/15 13:55:53 UTC

PR for Bug 55258

Hello,
Shall we merge :
https://github.com/apache/jmeter/pull/227

Regards
Philippe

Re: PR for Bug 55258

Posted by Philippe Mouawad <ph...@gmail.com>.
Thanks for feedback.
Integrated.
To be uniform, I added new to menu.


On Sun, Jan 22, 2017 at 2:27 PM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

> Am Sonntag, den 22.01.2017, 14:00 +0100 schrieb Philippe Mouawad:
> > Hello,
> > Any thoughts on this one ?
>
> While I wouldn't mind keeping both icons, it looks like the majority
> wanted to have only one icon and that one should be the "new" icon.
>
> In that light, it looks like the PR is OK.
>
> (I haven't looked at the docs, whether it is mentioned there, though)
>
> Felix
>
> > Thanks
> >
> > On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
> > p.mouawad@ubik-ingenierie.com> wrote:
> >
> > >
> > > Hello,
> > > Shall we merge :
> > > https://github.com/apache/jmeter/pull/227
> > >
> > > Regards
> > > Philippe
> > >
> > >
> >
>



-- 
Cordialement.
Philippe Mouawad.

Re: PR for Bug 55258

Posted by Felix Schumacher <fe...@internetallee.de>.
Am Sonntag, den 22.01.2017, 14:00 +0100 schrieb Philippe Mouawad:
> Hello,
> Any thoughts on this one ?

While I wouldn't mind keeping both icons, it looks like the majority
wanted to have only one icon and that one should be the "new" icon.

In that light, it looks like the PR is OK.

(I haven't looked at the docs, whether it is mentioned there, though)

Felix

> Thanks
> 
> On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
> p.mouawad@ubik-ingenierie.com> wrote:
> 
> > 
> > Hello,
> > Shall we merge :
> > https://github.com/apache/jmeter/pull/227
> > 
> > Regards
> > Philippe
> > 
> > 
> 

Re: PR for Bug 55258

Posted by Philippe Mouawad <p....@ubik-ingenierie.com>.
Hello,
Any thoughts on this one ?
Thanks

On Sun, Jan 15, 2017 at 2:55 PM, Philippe Mouawad <
p.mouawad@ubik-ingenierie.com> wrote:

> Hello,
> Shall we merge :
> https://github.com/apache/jmeter/pull/227
>
> Regards
> Philippe
>
>


-- 
Cordialement.
Philippe Mouawad.
Ubik-Ingénierie

UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/>

UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>