You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org> on 2006/05/10 15:31:04 UTC
[jira] Created: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
---------------------------------------------------------------------------------
Key: DERBY-1313
URL: http://issues.apache.org/jira/browse/DERBY-1313
Project: Derby
Type: Bug
Components: JDBC
Reporter: Fernanda Pizzorno
Assigned to: Fernanda Pizzorno
Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Fernanda Pizzorno updated DERBY-1313:
-------------------------------------
Attachment: derby-1313.diff
derby-1313.stat
In the server side, SQLDIAGGRP had been implemented on the DRDAConnThread, but it was commented out. This implementation has been uncommented in this patch and SQLDIAGGRP are now sent if the client requests diagnostic level != SQLDIAG0. The implementation of SQLDIAGGRP has also been changed so that only ROW_UPDATE AND ROW_DELETED warnings will be sent to the client.
The client has been changed so as to request diagnostic level SQLDIAG2 (which means that SQLDIAGGRP will be sent by the server, but the error message will not be sent), and to be able to parse SQLDIAGGRP.
A test has been added to SURTest that verifies that a row can return true for both rowUpdated() and rowDeleted().
Can someone please review this patch?
Thank you in advance :-).
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12413941 ]
Dag H. Wanvik commented on DERBY-1313:
--------------------------------------
Apart from the minor things mentioned below, I do not have further
comments on this patch. Looks good to me.
* DRDAConnThread.java:
In the last rev, this file seems to be formatted with 8 char wide
tab characters (maybe after Tomohito-san's formatting changes)
and your changes seem to have been made with tab width 4, so it
looks weird now. I suggest you either alert Tomohito to this (Derby
uses width 4 for tabs in most cases, or preferably just whitespace),
or adjust your changes to fit with tab width 8.
* SURTest.java:
Spurious character added on last column of line 12 (a comment line).
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12415241 ]
Dag H. Wanvik commented on DERBY-1313:
--------------------------------------
The way I interpret the description of DIAGLVL,
the implementation is compliant, even after DERBY-1374,
cf. this section of the specification of DIAGLVL:
"If DIAGLVL0 is specified or the default value is provided, the
SQLDIAGGRP is returned as a null group. The DIAGLVL0 may
be upgraded by the target server to DIAGLVL1 when executing
an EXCSQLSTT command or an OPNQRY command which
generates multiple error or warning conditions processing
the command."
After DERBY-1374 (a fix to this patch) the client no longer asks for
DIAGLVL2 as did this patch (since that broke old servers, cf.
explanation by Fernanda in DERBY-1374), but it seems it is ok (according
to the above), for the server to send at DIAGLVL1.
Of course, presently only the two warnings used for DERBY-1313 are ever
sent using level 1 but I think that's OK as far as compliance with
the protocol goes (server's discretion how much to send)
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Fernanda Pizzorno updated DERBY-1313:
-------------------------------------
Attachment: derby-1313v1.pdf
The attached document (derby-1313v1.pdf) contains a short description of the work done in DERBY-1313 and DERBY-1374, and some thoughts of what is needed in order to extend this work to cover other warnings and exception.
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v1.pdf, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12415363 ]
Kathey Marsden commented on DERBY-1313:
---------------------------------------
Thanks Dag for the check and the clarification.
Fernanda said:
This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
I would be of tremendous help to the community if there were a write up of what was done and how it might be exapanded to cover other warnings and multiple exceptions. There are oustanding issues (DERBY-159, DERBY-1011) related to this. There is a lot I don't understand about the change like how it fits into our current message localization scheme which uses a stored procedure to retrieve the message. Does the stored procedure get called multiple times for each row returning a warning? If so what impact might this have on transaction semantics and performance? etc...
Unfortunately I am not educated enough on change to ask intelligent questions. I hope others will pursue a more detailed review. As said a write up of the changes, their impact, and how they might be adapted to other cases would sure be helpful.
Kathey
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12415065 ]
Kathey Marsden commented on DERBY-1313:
---------------------------------------
I didn't get a chance to reveiew this patch before it went in but I was wondering: What are the Derby implementation specific uses of DRDA in this change if any? Do the reviewers and implementers feel comfortable with DRDA compliance?
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Bernt M. Johnsen (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Bernt M. Johnsen resolved DERBY-1313:
-------------------------------------
Resolution: Fixed
Committed revision 411167.
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12415498 ]
Fernanda Pizzorno commented on DERBY-1313:
------------------------------------------
Kathey,
I will upload a write up of that was done and how to expand it.
Fernanda
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12414337 ]
Dag H. Wanvik commented on DERBY-1313:
--------------------------------------
I checked it again, and it looks good. I recommend it be committed.
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (DERBY-1313) SUR: Use DRDA's extended diagnostic
to send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Dag H. Wanvik (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=comments#action_12413130 ]
Dag H. Wanvik commented on DERBY-1313:
--------------------------------------
Patch looks clean and good to me. Quite some work digging through
thoses specs and getting the details right!
It needs to be updated, though, I had to svn up to an older point in
time (I used May 17) to be able to apply the patch cleanly.
* NetCursor.java
- Several readFdoca* methods are very similar, and you have
introduced yet another. Use of some minion code would be in order
to remove redundancy here, I think, but maybe as part of another
patch.
- I also note that the parsing methods in general in NetCursor to a
large degree duplicate similar methods in NetConnectionReply;
candidate for refactoring, too. Another time...!
- It is OK that not all protocol elements have parsing code added,
since the server currently doesn't send them and you *do* throw an
exception if they are encountered (e.g. NetCursor#parseSQLDIAGCN).
Maybe a list somewhere (like an overview) of which elements are only
partially implemented would be nice. But this is probably more a
general peeve for this code. Your call (itch?) ;)
* DRDAConnThread.java
- spurious blank line introduced: 63
- wrong comment:
// DRDA diagnostic level -> DIAGLVL - SQL Error diagnistic level
// DIAGLVL1 (0xF0) - Null SQLDIAGRP (DEFAULT)
// DIAGLVL1 (0xF1) - Non-null SQLDIAGRP
// DIAGLVL1 (0xF2) - Non-null SQLDIAGRP, and null message text fields
private byte diagnosticLevel = (byte)0xF0;
They are all called DIAGLVL1 ;) Maybe point to CodePoint.java
instead to avoid redudancy?
* SURTest.java
- Is the detectability methods tested in connection with problems seen
in DERBY-1249, for the client case? Or should
testRowUpdateAndRowDeleted have some tests for the conflict case as
well?
Finally, you did not mention which tests have been run, if any?
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Kathey Marsden (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Kathey Marsden updated DERBY-1313:
----------------------------------
type: Improvement (was: Bug)
Fix Version: 10.2.0.0
Version: 10.2.0.0
Change to improvement and set affects and fix version
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Improvement
> Components: JDBC
> Versions: 10.2.0.0
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Fix For: 10.2.0.0
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v1.pdf, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Fernanda Pizzorno closed DERBY-1313:
------------------------------------
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Fernanda Pizzorno updated DERBY-1313:
-------------------------------------
Attachment: derby-1313v3.diff
derby-1313v3.stat
I am submitting a new patch with the following changes done to derby-1313.diff:
> * DRDAConnThread.java
> - spurious blank line introduced: 63
The blank line has been removed.
> - wrong comment:
>
> // DRDA diagnostic level -> DIAGLVL - SQL Error diagnistic level
> // DIAGLVL1 (0xF0) - Null SQLDIAGRP (DEFAULT)
> // DIAGLVL1 (0xF1) - Non-null SQLDIAGRP
> // DIAGLVL1 (0xF2) - Non-null SQLDIAGRP, and null message text fields
> private byte diagnosticLevel = (byte)0xF0;
>
> They are all called DIAGLVL1 ;) Maybe point to CodePoint.java
> instead to avoid redudancy?
This comment has been changed to:
// DRDA diagnostic level, DIAGLVL0 by default
I have successfully run derbyall. Can someone please review?
Thank you in advance.
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat, derby-1313v3.diff, derby-1313v3.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (DERBY-1313) SUR: Use DRDA's extended diagnostic to
send ROW_UPDATED and ROW_DELETED warnings.
Posted by "Fernanda Pizzorno (JIRA)" <de...@db.apache.org>.
[ http://issues.apache.org/jira/browse/DERBY-1313?page=all ]
Fernanda Pizzorno updated DERBY-1313:
-------------------------------------
Attachment: derby-1313v2.diff
derby-1313v2.stat
The patch derby-1313v2.diff addreses the review comments.
[...]
> * NetCursor.java
> - Several readFdoca* methods are very similar, and you have
> introduced yet another. Use of some minion code would be in order
> to remove redundancy here, I think, but maybe as part of another
> patch.
I don't think this should be done as a part of this patch
> - I also note that the parsing methods in general in NetCursor to a
> large degree duplicate similar methods in NetConnectionReply;
> candidate for refactoring, too. Another time...!
I agree that some refactoring could be done here, but I don't think
it should be done as a part of this issue.
> - It is OK that not all protocol elements have parsing code added,
> since the server currently doesn't send them and you *do* throw an
> exception if they are encountered (e.g. NetCursor#parseSQLDIAGCN).
> Maybe a list somewhere (like an overview) of which elements are only
> partially implemented would be nice. But this is probably more a
> general peeve for this code. Your call (itch?) ;)
The partially implemented elements introduced by this patch are:
- SQLDIAGSTT
- SQLDIAGCN
- SQLDCTOKS
- SQLDCXGRP
> * DRDAConnThread.java
> - spurious blank line introduced: 63
The blank line has been removed.
> - wrong comment:
>
> // DRDA diagnostic level -> DIAGLVL - SQL Error diagnistic level
> // DIAGLVL1 (0xF0) - Null SQLDIAGRP (DEFAULT)
> // DIAGLVL1 (0xF1) - Non-null SQLDIAGRP
> // DIAGLVL1 (0xF2) - Non-null SQLDIAGRP, and null message text fields
> private byte diagnosticLevel = (byte)0xF0;
>
> They are all called DIAGLVL1 ;) Maybe point to CodePoint.java
> instead to avoid redudancy?
This comment has been changed to:
// DRDA diagnostic level, DIAGLVL0 by default
> * SURTest.java
> - Is the detectability methods tested in connection with problems seen
> in DERBY-1249, for the client case? Or should
> testRowUpdateAndRowDeleted have some tests for the conflict case as
> well?
Detectability methods are tested in connection with cursor operation
conflict. These tests were added as a part of the work done for
DERBY-1251.
> Finally, you did not mention which tests have been run, if any?
I have successfully run derbyall.
> SUR: Use DRDA's extended diagnostic to send ROW_UPDATED and ROW_DELETED warnings.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-1313
> URL: http://issues.apache.org/jira/browse/DERBY-1313
> Project: Derby
> Type: Bug
> Components: JDBC
> Reporter: Fernanda Pizzorno
> Assignee: Fernanda Pizzorno
> Attachments: derby-1313.diff, derby-1313.stat, derby-1313v2.diff, derby-1313v2.stat
>
> Detectability of own changes is implemented in the client using warnings cf the write-up for DERBY-775. When a row has been deleted and/or updated, a warning will be sent to the client to indicate that fact. Presently, only one warning can be sent each time a data row is sent from to the client, that means that some warnings may be lost. Using extended diagnostic allows us to send several warnings for each data row.
> I propose to use extended diagnostics to send ROW_UPDATED and ROW_DELETED warnings when necessary. This may later be extended for other warnings, but I do not plan to do it as a part of the work in this issue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira