You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2015/05/08 23:28:06 UTC
Review Request 34001: [Refactor] Removes ExprNodeNullDesc.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34001/
-----------------------------------------------------------

Review request for hive and Gopal V.


Bugs: HIVE-10327
    https://issues.apache.org/jira/browse/HIVE-10327


Repository: hive-git


Description
-------

Removes ExprNodeNullDesc. Use ExprNodeConstantDesc in its place, which also contains type info additionally.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeEvaluatorFactory.java ff0ddc8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java b695bef 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeNullEvaluator.java 3aaf17c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java df39218 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConstantPropagateProcFactory.java f536ef6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupByOptimizer.java 1e47fcb 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/PrunerExpressionOperatorFactory.java e633fdc 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SimpleFetchOptimizer.java 0328007 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/RexNodeConverter.java abd7afd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/lineage/ExprProcFactory.java 86d221d 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java cbd4e6c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 01398f0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java a38511a 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java b15df0f 
  ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeNullDesc.java 25b16da 
  ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java 508d880 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFCoalesce.java 8890e69 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGreatest.java e919345 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFInstr.java 0a13ac9 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLocate.java 094f280 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPrintf.java cb6dd62 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTranslate.java 4ac542f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 09d2d1f 
  ql/src/test/results/clientpositive/annotate_stats_filter.q.out e8cd06d 
  ql/src/test/results/clientpositive/input6.q.out 38c9fe1 
  ql/src/test/results/clientpositive/join_nullsafe.q.out 9bdfcbd 
  ql/src/test/results/clientpositive/subquery_notin_having.q.java1.7.out 2d5b486 
  ql/src/test/results/clientpositive/vector_coalesce.q.out c63f2d1 
  serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java a165b84 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java baa4a94 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableVoidObjectInspector.java f3f4838 

Diff: https://reviews.apache.org/r/34001/diff/


Testing
-------

Refactoring patch. Existing regression tests will suffice.


Thanks,

Ashutosh Chauhan