You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/04/28 08:07:38 UTC

[GitHub] flink pull request #3796: [FLINK-6293] [tests] Harden JobManagerITCase

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/3796

    [FLINK-6293] [tests] Harden JobManagerITCase

    One of the unit tests in JobManagerITCase starts a MiniCluster and sends a
    LeaderSessionMessage to the JobManager without waiting until the JobManager
    has gained leadership. This can lead to a dropped TriggerSavepoint message
    which will cause the test to deadlock.
    
    This PR fixes the problem by explicitly waiting for the JobManager to become
    the leader.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixJobManagerITCase

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3796.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3796
    
----
commit 5abf141c489154f1fc5650a27b0eb19dbaa29e75
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-04-28T08:04:57Z

    [FLINK-6293] [tests] Harden JobManagerITCase
    
    One of the unit tests in JobManagerITCase starts a MiniCluster and sends a
    LeaderSessionMessage to the JobManager without waiting until the JobManager
    has gained leadership. This can lead to a dropped TriggerSavepoint message
    which will cause the test to deadlock.
    
    This PR fixes the problem by explicitly waiting for the JobManager to become
    the leader.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3796: [FLINK-6293] [tests] Harden JobManagerITCase

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3796


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3796: [FLINK-6293] [tests] Harden JobManagerITCase

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/3796
  
    Good fix. +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3796: [FLINK-6293] [tests] Harden JobManagerITCase

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:

    https://github.com/apache/flink/pull/3796
  
    Thanks for the review @uce. Merging this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---