[GitHub] [beam] ryucc commented on a diff in pull request #25265: Support samza portable UDF metrics.

["ryucc (via GitHub)" <gi...@apache.org>]

ryucc commented on code in PR #25265:
URL: https://github.com/apache/beam/pull/25265#discussion_r1095456993


##########
runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/SamzaMetricsBundleProgressHandler.java:
##########
@@ -90,7 +90,9 @@ public void onProgress(BeamFnApi.ProcessBundleProgressResponse progress) {}
   public void onCompleted(BeamFnApi.ProcessBundleResponse response) {
     response.getMonitoringInfosList().stream()
         .filter(monitoringInfo -> !monitoringInfo.getPayload().isEmpty())
-        .forEach(this::parseAndUpdateMetric);
+        .map(this::parseAndUpdateMetric)
+        .distinct()
+        .forEach(samzaMetricsContainer::updateMetrics);

Review Comment:
   Metrics doesn't work without this line in local testing.
   
   samzaMetricsContainer probably has copies of both a samza metrics type and a beam metrics type. This line triggers the copy from beam to samza metrics



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org