You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/04 08:51:19 UTC
[GitHub] [iotdb] qiaojialin opened a new pull request, #7909: Adjust configuration files
qiaojialin opened a new pull request, #7909:
URL: https://github.com/apache/iotdb/pull/7909
1. Adjust the order of parameters in xx.properties for easy use
2. Change disk_space_warning_threshold from 5.0 to 0.05
3. Change default cn_internal_address/dn_internal_address/dn_rpc_address from 0.0.0.0 to 127.0.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1303471746
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [9.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1304702954
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1304374497
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1304424107
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes commented on a diff in pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
Beyyes commented on code in PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#discussion_r1013788675
##########
confignode/src/assembly/resources/conf/iotdb-confignode.properties:
##########
@@ -21,42 +21,33 @@
### Config Node RPC Configuration
####################
-
-# Used for cluster internal RPC communication.
-# Could set 0.0.0.0, 127.0.0.1(for local test) or ipv4 address.
+# Used for RPC communication inside cluster.
+# Could set 127.0.0.1(for local test) or ipv4 address.
# Datatype: String
-cn_internal_address=0.0.0.0
-
+cn_internal_address=127.0.0.1
-# Used for cluster internal RPC communication
+# Used for RPC communication inside cluster.
# Datatype: int
cn_internal_port=22277
-
-# Used for ConfigNodeGroup's ConsensusLayer interior communication
+# Used for communication among ConfigNodes inside cluster.
Review Comment:
```suggestion
# Used for consensus communication among ConfigNodes inside cluster.
```
is better?
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -155,39 +155,39 @@ public class ConfigNodeConfig {
*/
private long dataRegionRatisSnapshotTriggerThreshold = 400000L;
- private long partitionRegionRatisSnapshotTriggerThreshold = 400000L;
- private long partitionRegionOneCopySnapshotTriggerThreshold = 400000L;
+ private long configNodeRatisSnapshotTriggerThreshold = 400000L;
+ private long configNodeOneCopySnapshotTriggerThreshold = 400000L;
Review Comment:
I will replace `OneCopy` to `Simple` next pr
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -15,77 +15,311 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
####################
-### Thrift Configuration
+### Replication configuration
####################
-# Datatype: boolean
-# rpc_thrift_compression_enable=false
+# ConfigNode consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# config_node_consensus_protocol_class=org.apache.iotdb.consensus.ratis.RatisConsensus
-# if true, a snappy based compression method will be called before sending data by the network
+# Default number of schema replicas
+# Can not be changed after the first start
+# Datatype: int
+# schema_replication_factor=1
+
+# SchemaRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# schema_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+# Default number of data replicas
+# Can not be changed after the first start
+# Datatype: int
+# data_replication_factor=1
+
+# DataRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.multileader.MultiLeaderConsensus
+# 3. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# data_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+####################
+### Partition (Load balancing) configuration
+####################
+
+# All parameters in PartitionSlot configuration is unmodifiable after ConfigNode starts for the first time.
Review Comment:
```suggestion
# All parameters in Partition configuration is unmodifiable after ConfigNode starts for the first time.
```
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -15,77 +15,311 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
####################
-### Thrift Configuration
+### Replication configuration
####################
-# Datatype: boolean
-# rpc_thrift_compression_enable=false
+# ConfigNode consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# config_node_consensus_protocol_class=org.apache.iotdb.consensus.ratis.RatisConsensus
-# if true, a snappy based compression method will be called before sending data by the network
+# Default number of schema replicas
+# Can not be changed after the first start
+# Datatype: int
+# schema_replication_factor=1
+
+# SchemaRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# schema_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+# Default number of data replicas
+# Can not be changed after the first start
+# Datatype: int
+# data_replication_factor=1
+
+# DataRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.multileader.MultiLeaderConsensus
+# 3. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# data_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+####################
+### Partition (Load balancing) configuration
+####################
+
+# All parameters in PartitionSlot configuration is unmodifiable after ConfigNode starts for the first time.
+# And these parameters should be consistent within the ConfigNodeGroup.
+# Number of SeriesPartitionSlots per StorageGroup
+# Datatype: int
+# series_partition_slot_num=10000
+
+# SeriesPartitionSlot executor class
+# These hashing algorithms are currently supported:
+# 1. BKDRHashExecutor(Default)
+# 2. APHashExecutor
+# 3. JSHashExecutor
+# 4. SDBMHashExecutor
+# Also, if you want to implement your own SeriesPartition executor, you can inherit the SeriesPartitionExecutor class and
+# modify this parameter to correspond to your Java class
+# Datatype: String
+# series_partition_executor_class=org.apache.iotdb.commons.partition.executor.hash.BKDRHashExecutor
+
+# The maximum number of SchemaRegion expected to be managed by each DataNode.
+# Notice: Since each StorageGroup requires at least one SchemaRegion to manage its schema,
+# this parameter doesn't limit the number of SchemaRegions when there are too many StorageGroups.
+# Datatype: Double
+# schema_region_per_data_node=1.0
+
+# The maximum number of DataRegion expected to be managed by each processor.
+# Notice: Since each StorageGroup requires at least two DataRegions to manage its data,
+# this parameter doesn't limit the number of DataRegions when there are too many StorageGroups.
+# Datatype: Double
+# data_region_per_processor=0.5
+
+# Region allocate strategy
+# These allocate strategies are currently supported:
+# 1. GREEDY(Default, when region is allocated, always choose the dataNode that has bean allocated the least regions)
Review Comment:
```suggestion
# 1. GREEDY(Default, when region is allocated, always choose the dataNode that has been allocated the minimum regions)
```
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -15,77 +15,311 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
####################
-### Thrift Configuration
+### Replication configuration
####################
-# Datatype: boolean
-# rpc_thrift_compression_enable=false
+# ConfigNode consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# config_node_consensus_protocol_class=org.apache.iotdb.consensus.ratis.RatisConsensus
-# if true, a snappy based compression method will be called before sending data by the network
+# Default number of schema replicas
+# Can not be changed after the first start
+# Datatype: int
+# schema_replication_factor=1
+
+# SchemaRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# schema_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+# Default number of data replicas
+# Can not be changed after the first start
+# Datatype: int
+# data_replication_factor=1
+
+# DataRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.multileader.MultiLeaderConsensus
+# 3. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# data_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+####################
+### Partition (Load balancing) configuration
+####################
+
+# All parameters in PartitionSlot configuration is unmodifiable after ConfigNode starts for the first time.
+# And these parameters should be consistent within the ConfigNodeGroup.
+# Number of SeriesPartitionSlots per StorageGroup
+# Datatype: int
+# series_partition_slot_num=10000
+
+# SeriesPartitionSlot executor class
+# These hashing algorithms are currently supported:
+# 1. BKDRHashExecutor(Default)
+# 2. APHashExecutor
+# 3. JSHashExecutor
+# 4. SDBMHashExecutor
+# Also, if you want to implement your own SeriesPartition executor, you can inherit the SeriesPartitionExecutor class and
+# modify this parameter to correspond to your Java class
+# Datatype: String
+# series_partition_executor_class=org.apache.iotdb.commons.partition.executor.hash.BKDRHashExecutor
+
+# The maximum number of SchemaRegion expected to be managed by each DataNode.
+# Notice: Since each StorageGroup requires at least one SchemaRegion to manage its schema,
+# this parameter doesn't limit the number of SchemaRegions when there are too many StorageGroups.
+# Datatype: Double
+# schema_region_per_data_node=1.0
+
+# The maximum number of DataRegion expected to be managed by each processor.
+# Notice: Since each StorageGroup requires at least two DataRegions to manage its data,
Review Comment:
`at least two DataRegions to manage its data` is inappropriate?
##########
server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java:
##########
@@ -1037,8 +1037,8 @@ private void sampleDiskLoad(TLoadSample loadSample) {
.value();
if (freeDisk != 0 && totalDisk != 0) {
- double freeDiskRatio = (double) freeDisk * 100 / totalDisk;
- loadSample.setDiskUsageRate(100.0 - freeDiskRatio);
+ double freeDiskRatio = (double) freeDisk / totalDisk;
+ loadSample.setDiskUsageRate(1 - freeDiskRatio);
Review Comment:
1.0?
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -15,77 +15,311 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-#
####################
-### Thrift Configuration
+### Replication configuration
####################
-# Datatype: boolean
-# rpc_thrift_compression_enable=false
+# ConfigNode consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# config_node_consensus_protocol_class=org.apache.iotdb.consensus.ratis.RatisConsensus
-# if true, a snappy based compression method will be called before sending data by the network
+# Default number of schema replicas
+# Can not be changed after the first start
+# Datatype: int
+# schema_replication_factor=1
+
+# SchemaRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# schema_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+# Default number of data replicas
+# Can not be changed after the first start
+# Datatype: int
+# data_replication_factor=1
+
+# DataRegion consensus protocol type.
+# This parameter is unmodifiable after ConfigNode starts for the first time.
+# These consensus protocols are currently supported:
+# 1. org.apache.iotdb.consensus.simple.SimpleConsensus
+# 2. org.apache.iotdb.consensus.multileader.MultiLeaderConsensus
+# 3. org.apache.iotdb.consensus.ratis.RatisConsensus
+# Datatype: String
+# data_region_consensus_protocol_class=org.apache.iotdb.consensus.simple.SimpleConsensus
+
+####################
+### Partition (Load balancing) configuration
+####################
+
+# All parameters in PartitionSlot configuration is unmodifiable after ConfigNode starts for the first time.
+# And these parameters should be consistent within the ConfigNodeGroup.
+# Number of SeriesPartitionSlots per StorageGroup
+# Datatype: int
+# series_partition_slot_num=10000
+
+# SeriesPartitionSlot executor class
+# These hashing algorithms are currently supported:
+# 1. BKDRHashExecutor(Default)
+# 2. APHashExecutor
+# 3. JSHashExecutor
+# 4. SDBMHashExecutor
+# Also, if you want to implement your own SeriesPartition executor, you can inherit the SeriesPartitionExecutor class and
+# modify this parameter to correspond to your Java class
+# Datatype: String
+# series_partition_executor_class=org.apache.iotdb.commons.partition.executor.hash.BKDRHashExecutor
+
+# The maximum number of SchemaRegion expected to be managed by each DataNode.
+# Notice: Since each StorageGroup requires at least one SchemaRegion to manage its schema,
+# this parameter doesn't limit the number of SchemaRegions when there are too many StorageGroups.
+# Datatype: Double
+# schema_region_per_data_node=1.0
+
+# The maximum number of DataRegion expected to be managed by each processor.
+# Notice: Since each StorageGroup requires at least two DataRegions to manage its data,
+# this parameter doesn't limit the number of DataRegions when there are too many StorageGroups.
+# Datatype: Double
+# data_region_per_processor=0.5
+
+# Region allocate strategy
+# These allocate strategies are currently supported:
+# 1. GREEDY(Default, when region is allocated, always choose the dataNode that has bean allocated the least regions)
+# 2. COPY_SET(Random replication according to wight calculated from number of regions on all online dataNodes, suitable for large clusters)
Review Comment:
```suggestion
# 2. COPY_SET(Random replication according to weight calculated from number of regions on all online dataNodes, suitable for large clusters)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1304395388
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #7909:
URL: https://github.com/apache/iotdb/pull/7909#issuecomment-1304369216
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=7909)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=7909&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=7909&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7909: Adjust configuration files
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7909:
URL: https://github.com/apache/iotdb/pull/7909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org