You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/02/21 22:24:00 UTC
[jira] [Commented] (KAFKA-9553) Transaction state loading metric
does not count total loading time
[ https://issues.apache.org/jira/browse/KAFKA-9553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042210#comment-17042210 ]
ASF GitHub Bot commented on KAFKA-9553:
---------------------------------------
agam commented on pull request #8155: KAFKA-9553: Improve measurement for loading groups and transactions
URL: https://github.com/apache/kafka/pull/8155
Changes:
- Pull out sensor update to top-level
- Shifted up the partition-loading sensor measurement for loading transactions
- Added scheduler-time awareness for loading groups
Tests:
- Modified test to reflect new scheduling call
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Transaction state loading metric does not count total loading time
> ------------------------------------------------------------------
>
> Key: KAFKA-9553
> URL: https://issues.apache.org/jira/browse/KAFKA-9553
> Project: Kafka
> Issue Type: Bug
> Reporter: Jason Gustafson
> Assignee: Agam Brahma
> Priority: Major
>
> KIP-484 added a metric to track total loading time for internal topics: https://cwiki.apache.org/confluence/display/KAFKA/KIP-484%3A+Expose+metrics+for+group+and+transaction+metadata+loading+duration. The value seems to be being updated incorrectly in TransactionStateManager. Rather than recording the total loading time, it records the loading separately after every read from the log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)