You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/04/28 09:21:08 UTC

[Bug 57864] New: channelSendOptions attribute is not able to be configured in hexadecimal

https://bz.apache.org/bugzilla/show_bug.cgi?id=57864

            Bug ID: 57864
           Summary: channelSendOptions attribute is not able to be
                    configured in hexadecimal
           Product: Tomcat 8
           Version: trunk
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Documentation
          Assignee: dev@tomcat.apache.org
          Reporter: nakamura.kyohei.lab@gmail.com

Created attachment 32693
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32693&action=edit
patch against trunk.

The Cluster configuration document have shown that the channelSendOptions
attribute of SimpleTcpCluster element can be configured in hexadecimal.
http://tomcat.apache.org/tomcat-8.0-doc/config/cluster.html

Digester set the value using IntrospectionUtils.setProperty method.
SimpleTcpCluster.setChannelSendOptions method takes an int argument.

Therefore, setProperty method will be attempted to convert hexadecimal using
Constructor of Integer Class (See Integer(String s)).
As a result, hexadecimal value will cause a NumberFormatException.

So, the channelSendOptions is not able to be configured in hexadecimal.

On the other hand, when GroupChannel is used on Tomcat, the channelSendOptions
will be set 10 or less (SYNC or ASYNC, ACK or Non-ACK), and it will be not set
more than 10.
Therefore, the example for hexadecimal ("0x000B") can be remove from the
configuration document.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57864] channelSendOptions attribute is not able to be configured in hexadecimal

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57864

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Thanks for the report and the patch. I have applied a variation of the patch to
trunk (for 9.0.x), tc8.0.x/trunk (for 8.0.22 onwards), tc7.0.x/trunk (for
7.0.62 onwards) and tc6.0.x/trunk for 6.0.44 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org