You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/09/03 14:06:33 UTC
[GitHub] [activemq-artemis] ViliusS opened a new pull request, #4204: NO-JIRA Update Artemis download URL when creating a docker image
ViliusS opened a new pull request, #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204
https://dlcdn.apache.org/ contains only current releases. This change
allows to create a docker image for any ActiveMQ Artemis version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram closed pull request #4204: ARTEMIS-3982 Update Artemis download URL when creating a docker image
Posted by GitBox <gi...@apache.org>.
jbertram closed pull request #4204: ARTEMIS-3982 Update Artemis download URL when creating a docker image
URL: https://github.com/apache/activemq-artemis/pull/4204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] brusdev commented on a diff in pull request #4204: NO-JIRA Update Artemis download URL when creating a docker image
Posted by GitBox <gi...@apache.org>.
brusdev commented on code in PR #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204#discussion_r965186043
##########
artemis-docker/prepare-docker.sh:
##########
@@ -124,7 +124,7 @@ if [ -n "${FROM_RELEASE}" ]; then
cleanup
- ARTEMIS_BASE_URL="$(curl -s https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
+ ARTEMIS_BASE_URL="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/"
Review Comment:
```suggestion
ARTEMIS_BASE_URL="$(curl -s https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
if ! curl --output /dev/null --silent --head --fail "${ARTEMIS_BASE_URL}"; then
ARTEMIS_BASE_URL="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/"
fi
```
The mirrored url should preferred if it exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on pull request #4204: ARTEMIS-3982 Update Artemis download URL when creating a docker image
Posted by GitBox <gi...@apache.org>.
jbertram commented on PR #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204#issuecomment-1247316033
I was browsing through Jira today and found [ARTEMIS-3748](https://issues.apache.org/jira/browse/ARTEMIS-3748) so I sent & merged #4215. Unfortunately it happens to have been the same issue as this. I've closed ARTEMIS-3982 accordingly. Sorry for missing this PR (it wasn't linked to the Jira), but thanks for the contribution all the same!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] michaelandrepearce commented on pull request #4204: NO-JIRA Update Artemis download URL when creating a docker image
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on PR #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204#issuecomment-1239948937
Jira please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] ViliusS commented on pull request #4204: ARTEMIS-3982 Update Artemis download URL when creating a docker image
Posted by GitBox <gi...@apache.org>.
ViliusS commented on PR #4204:
URL: https://github.com/apache/activemq-artemis/pull/4204#issuecomment-1247668640
@jbertram what is correct way to link Jira ticket to GitHub PR? I browsed documentation but didn't find anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org