You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/11/18 19:49:27 UTC
[GitHub] couchdb-couch-mrview pull request: Rewrite via query server
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-couch-mrview/pull/36
Rewrite via query server
COUCHDB-2874
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-couch-mrview 2874-rewrite-func
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch-mrview/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 946d942a481c7bae8b1f8045a8909bf921a20e3a
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-11-10T17:44:25Z
Rewrite ddoc validation routines
While it solve the own problem well, it contains few design issues that
makes unable to keep it for further updates:
1. It's type-centric validation. However, our ddocs have quite complex
structure and validation logic, so it eventually have to write special
clause for most of the validated fields turning it into field-centric.
2. It mixes logic of type checking and relation checking.
Here we turn it into rule based validation where each rule is a path of
field-type pairs while all relation checks are moved into own functions.
Moreover, we can now exactly say the path for the field that caused
issues.
commit 6c9833d667e319b82a7a1fffb8ba92116534e63f
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-11-10T17:55:02Z
Accept rewrites as string function
COUCHDB-2874
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Rewrite via query server
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch-mrview/pull/36#issuecomment-157821196
Sorry @nickva, I had no choice. ):
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch-mrview pull request: Rewrite via query server
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch-mrview/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---