You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/05 02:18:29 UTC

[GitHub] [pulsar] zymap opened a new pull request, #17462: [fix][license] Update the log4j version in the presto license file

zymap opened a new pull request, #17462:
URL: https://github.com/apache/pulsar/pull/17462

   
   ### Motivation
   
   We update the log4j version in [PR](https://github.com/apache/pulsar/pull/16884),
   but we haven't update the license file for the version.
   
   ### Modifications
   
   update the log4j version in license file to the correct version
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17462: [fix][license] Update the log4j version in the presto license file

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17462:
URL: https://github.com/apache/pulsar/pull/17462#issuecomment-1236483110

   This refers to https://github.com/apache/pulsar/issues/16783.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #17462: [fix][license] Update the log4j version in the presto license file

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17462:
URL: https://github.com/apache/pulsar/pull/17462


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #17462: [fix][license] Update the log4j version in the presto license file

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17462:
URL: https://github.com/apache/pulsar/pull/17462#issuecomment-1237113872

   @eolivelli as commented above, this refers to https://github.com/apache/pulsar/issues/16783.
   
   I don't find some time to see how to fix it, though XD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Jason918 commented on pull request #17462: [fix][license] Update the log4j version in the presto license file

Posted by GitBox <gi...@apache.org>.
Jason918 commented on PR #17462:
URL: https://github.com/apache/pulsar/pull/17462#issuecomment-1238892059

   After cherry-pick this to branch-2.10, build with `mvn clean install -DskipTests`
   
   `src/check-binary-license.sh` fails with:
   
   ![image](https://user-images.githubusercontent.com/2770146/188788209-4a44990a-f173-4098-b04a-957746719985.png)
   
   So remove label `release/2.10.2`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org