You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/15 14:09:48 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #19237: [fix][ci] Fox codecov reporting by configuring to wait for all builds sending coverage

lhotari opened a new pull request, #19237:
URL: https://github.com/apache/pulsar/pull/19237

   ### Motivation
   
   - currently the codecov reporting processes the uploaded coverage reports too early and thus the coverage result is invalid.
   - the `after_n_builds` configuration setting should be used for waiting for all builds to finish before merging the coverage reports from parallel builds.
     - see https://docs.codecov.com/docs/notifications#preventing-notifications-until-after-n-builds
   
   ### Modifications
   
   Set `after_n_builds` to 10.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383527048

   > The final codecov result of comparison in PR comment is not accurated because the `master` branch CI should run after every PR merged, but now it doesn't because pulsar's CI runner resource is not sufficient and it needs long time to finish. Maybe the first thing is that we need to shorten the unit test running time.
   
   My assumption is that the main reason for the false comparison results have been the missing `after_n_builds` setting. It's true that it won't be exactly accurate if master branch results are outdated. 
   
   Let's see if this assumption holds. The codecov upload was still missing from the 10th build job that resides in ci-pulsar-flaky.yaml and that's why the results didn't show up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383363518

   The final codecov result of comparison in PR comment is not accurated because the `master` branch CI should run after every PR merged, but now it doesn't because pulsar's CI runner resource is not sufficient and it needs long time to finish. Maybe the first thing is that we need to shorten the unit test running time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384853857

   > One more attempt.
   > 
   > The coverage profile wasn't activated for the BROKER_FLAKY unit test group:
   > 
   > https://github.com/apache/pulsar/blob/f23363c6f50b89b7dcb658c06ffaaf496bb65a86/build/run_unit_group.sh#L36-L40
   > 
   > @yaalsn Do you remember the reason for doing this?
   > 
   > In addition, the coverage profile wasn't activated when the install target (maven goal) was used instead of verify. I fixed the issues in the run_unit_group.sh script and also upgraded jacoco-maven-plugin to 0.8.8 . Jacoco 0.8.8 officially supports Java 17: https://github.com/jacoco/jacoco/releases/tag/v0.8.8
   
   The flaky test group allows failure when running CI, if any test fails during the flaky test group running, the result will be not accurated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383630982

   > @yaalsn Do you remember the reason for doing this?
   
   I found this description in #18081 "Except flaky test group to run code coverage, otherwise we cannot get an accurate base coverage." 
   Why would that make it more accurate? We have a lot of tests in the flaky test group.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #19237:
URL: https://github.com/apache/pulsar/pull/19237


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383830109

   codecov has a known issue https://github.com/codecov/codecov-action/issues/598 where uploading to codecov might fail with this error 
   ```
   [2023-01-16T10:14:31.630Z] ['info'] Pinging Codecov: https://codecov.io/upload/v4?package=github-action-3.1.1-uploader-0.3.2&token=*******&branch=lh-fix-codecov-config-to-wait-for-all-unit-tests&build=3928945879&build_url=https%3A%2F%2Fgithub.com%2Fapache%2Fpulsar%2Factions%2Fruns%2F3928945879&commit=b8189e0dfe212686a6aba0319866ee8f996dc796&job=Pulsar+CI&pr=19237&service=github-actions&slug=apache%2Fpulsar&name=&tag=&flags=unittests&parent=
   [2023-01-16T10:14:32.646Z] ['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
   ```
   
   It's too bad that there isn't a way to retry uploading in this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384878024

   
   > The flaky test group allows failure when running CI, if any test fails during the flaky test group running, the result will be not accurated.
   
   A few flaky tests won't contribute several percentage difference in coverage.
   The problem might be caused by the special FailFastListener which will skip all remaining tests for a specific forked test process.  I'll create a PR to disable fail fast mode for the flaky build job.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383941922

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19237](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71230c7) into [master](https://codecov.io/gh/apache/pulsar/commit/246c2701e5c43e02e9783c82d4d107d06b019951?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (246c270) will **decrease** coverage by `11.14%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19237/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19237       +/-   ##
   =============================================
   - Coverage     43.01%   31.86%   -11.15%     
   + Complexity    10167     6153     -4014     
   =============================================
     Files           747      633      -114     
     Lines         72255    59929    -12326     
     Branches       7786     6251     -1535     
   =============================================
   - Hits          31080    19099    -11981     
   - Misses        37577    38205      +628     
   + Partials       3598     2625      -973     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `31.86% <ø> (-11.15%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ava/org/apache/pulsar/broker/admin/v1/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...va/org/apache/pulsar/broker/admin/v1/Clusters.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9DbHVzdGVycy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../org/apache/pulsar/broker/admin/v1/Properties.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Qcm9wZXJ0aWVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../apache/pulsar/broker/admin/v2/ResourceGroups.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9SZXNvdXJjZUdyb3Vwcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...sar/broker/stats/metrics/ManagedLedgerMetrics.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9tZXRyaWNzL01hbmFnZWRMZWRnZXJNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ar/common/naming/PartitionedManagedLedgerInfo.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvUGFydGl0aW9uZWRNYW5hZ2VkTGVkZ2VySW5mby5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ker/service/schema/exceptions/SchemaException.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9leGNlcHRpb25zL1NjaGVtYUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...naming/RangeEquallyDivideBundleSplitAlgorithm.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvUmFuZ2VFcXVhbGx5RGl2aWRlQnVuZGxlU3BsaXRBbGdvcml0aG0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...e/pulsar/broker/admin/impl/ResourceQuotasBase.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1Jlc291cmNlUXVvdGFzQmFzZS5qYXZh) | `0.00% <0.00%> (-96.43%)` | :arrow_down: |
   | [...he/pulsar/broker/service/AnalyzeBacklogResult.java](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0FuYWx5emVCYWNrbG9nUmVzdWx0LmphdmE=) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
   | ... and [329 more](https://codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fox codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383160706

   Code coverage was activated in #17382 . @yaalsn would you mind reviewing this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] yaalsn commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
yaalsn commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383356748

   It would be better to add `after_n_builds`, thanks for your improvement! After every CI finishes, the codecov will update the result in the comment and its platform, so currently the final result is right. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1383626356

   One more attempt.
   
   The coverage profile wasn't activated for the BROKER_FLAKY unit test group: https://github.com/apache/pulsar/blob/f23363c6f50b89b7dcb658c06ffaaf496bb65a86/build/run_unit_group.sh#L36-L40
   
   @yaalsn Do you remember the reason for doing this?
   
   In addition, the coverage profile wasn't activated when the install target (maven goal) was used instead of verify. I fixed the issues in the run_unit_group.sh script and also upgraded jacoco-maven-plugin to 0.8.8 . 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19237: [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-1384996789

   
   > The flaky test group allows failure when running CI, if any test fails during the flaky test group running, the result will be not accurated.
   
   @yaalsn The flaky test group doesn't allow failures when running CI. It's the "quarantine" group. We don't have many tests in that group.
   
   I took a look at the reasons for differences. It's caused by builds that fail because of flaky tests in the master branch. That's why the coverage metrics for the base commit will be wrong.
   The Pulsar master branch builds have been failing recently because of a high number of very flaky tests. 
   This is the link to list pulsar-ci builds for the master branch:
   https://github.com/apache/pulsar/actions/workflows/pulsar-ci.yaml?query=branch%3Amaster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][ci] Fix codecov reporting by configuring to wait for all builds sending coverage [pulsar]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19237:
URL: https://github.com/apache/pulsar/pull/19237#issuecomment-4188019319

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/19237?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 47.13%. Comparing base ([`246c270`](https://app.codecov.io/gh/apache/pulsar/commit/246c2701e5c43e02e9783c82d4d107d06b019951?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`71230c7`](https://app.codecov.io/gh/apache/pulsar/commit/71230c7fed9cda39622969f3d0a375d8e1acca2d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2988 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/19237/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/19237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #19237      +/-   ##
   ============================================
   + Coverage     43.01%   47.13%   +4.12%     
   - Complexity    10167    18785    +8618     
   ============================================
     Files           747     1622     +875     
     Lines         72255   132116   +59861     
     Branches       7786    14542    +6756     
   ============================================
   + Hits          31080    62272   +31192     
   - Misses        37577    63555   +25978     
   - Partials       3598     6289    +2691     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/19237/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/19237/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.13% <ø> (+4.12%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   [see 1048 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/19237/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org