[GitHub] [pulsar-client-go] michaeljmarshall commented on a diff in pull request #809: [issue #807] dlq topic producer options

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #809:
URL: https://github.com/apache/pulsar-client-go/pull/809#discussion_r962087508


##########
pulsar/dlq_router.go:
##########
@@ -135,12 +135,16 @@ func (r *dlqRouter) getProducer(schema Schema) Producer {
 	// Retry to create producer indefinitely
 	backoff := &internal.Backoff{}
 	for {
-		producer, err := r.client.CreateProducer(ProducerOptions{
-			Topic:                   r.policy.DeadLetterTopic,
-			CompressionType:         LZ4,
-			BatchingMaxPublishDelay: 100 * time.Millisecond,

Review Comment:
   So just to be explicit, this effectively changes the `BatchingMaxPublishDelay` from 100 millis to the producer default, which is first 0 millis and then is overridden to 10 millis in the producer's constructor. Given that this would otherwise require merging producer options, I think this is fine as long as we document it in the release notes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org