[GitHub] betodealmeida commented on a change in pull request #5083: Add more time grains

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5083: Add more time grains
URL: https://github.com/apache/incubator-superset/pull/5083#discussion_r191514188
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -1357,6 +1360,27 @@ class DruidEngineSpec(BaseEngineSpec):
     engine = 'druid'
     inner_joins = False
 
+    time_grains = (
+        Grain('Time Column', _('Time Column'), '{col}', None),
+        Grain(
 
 Review comment:
   The linter would then complain. :-/
   
   But I'm changing the grains to use the `FLOOR` function, and then this unit will go away.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org