You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/10 14:03:48 UTC
[GitHub] [incubator-nuttx] patacongo commented on issue #764: Minor netlink
fix
patacongo commented on issue #764: Minor netlink fix
URL: https://github.com/apache/incubator-nuttx/pull/764#issuecomment-612042222
I lot of this is good code clean-up. And there is some that I don't fully understand. I trust that you have verified operation of the netlink sockets. There is a test for NETLINK_ROUTE at apps/examples/netlink_route.
The removal of netlink_notify_response() concerns me most. This was cause the caller to block until the response to the netlink command is received. I think that they issue that you are addressing is that this is used in netlink_poll() which should not block. Is that correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services