You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by sarangan12 <gi...@git.apache.org> on 2016/01/20 03:14:28 UTC
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
GitHub user sarangan12 opened a pull request:
https://github.com/apache/cordova-medic/pull/69
CB-10390: ADB doesn't recognize existing devices in Medic
In Apache CI, we get the error: ADB doesn't recognize existing devices
in Medic. The root cause for this error is that there is an additional
space in the pattern. As a result ‘emulator-5554’ will not be matched
with ‘emulator ‘ pattern (due to additional space). On removing the
additional space, the pattern matching working fine.
Also, when you run adb devices command, there will be a header line
“List of devices” will be displayed which must be ignored. Added the
code to ignore that also.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sarangan12/cordova-medic master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-medic/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
----
commit 2c9e1d33cace0f046ba0989b56fc5ebe845c42c0
Author: Sarangan Rajamanickam <sa...@yahoo.com>
Date: 2016-01-20T02:12:42Z
CB-10390: ADB doesn't recognize existing devices in Medic
In Apache CI, we get the error: ADB doesn't recognize existing devices
in Medic. The root cause for this error is that there is an additional
space in the pattern. As a result ‘emulator-5554’ will not be matched
with ‘emulator ‘ pattern (due to additional space). On removing the
additional space, the pattern matching working fine.
Also, when you run adb devices command, there will be a header line
“List of devices” will be displayed which must be ignored. Added the
code to ignore that also.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/69#issuecomment-173358200
Good catch, @sarangan12!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/69#issuecomment-173323145
@alsorokin to review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
Posted by sarangan12 <gi...@git.apache.org>.
Github user sarangan12 commented on the pull request:
https://github.com/apache/cordova-medic/pull/69#issuecomment-173062219
@dblotsky @nikhilkh @riknoll Can you please check and merge this request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-medic pull request: CB-10390: ADB doesn't recognize existi...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/69#issuecomment-173346488
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org