You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sqoop.apache.org by ab...@apache.org on 2014/12/24 03:06:38 UTC

sqoop git commit: SQOOP-1944: Sqoop2: No (or wrong) log message when Derby server startup/shutdown unexpectedly

Repository: sqoop
Updated Branches:
  refs/heads/sqoop2 13c01625a -> 0cfeb1982


SQOOP-1944: Sqoop2: No (or wrong) log message when Derby server startup/shutdown unexpectedly

(Qian Xu via Abraham Elmahrek)


Project: http://git-wip-us.apache.org/repos/asf/sqoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/sqoop/commit/0cfeb198
Tree: http://git-wip-us.apache.org/repos/asf/sqoop/tree/0cfeb198
Diff: http://git-wip-us.apache.org/repos/asf/sqoop/diff/0cfeb198

Branch: refs/heads/sqoop2
Commit: 0cfeb198278319acc62687cb0bf60b2f56c5ad18
Parents: 13c0162
Author: Abraham Elmahrek <ab...@apache.org>
Authored: Tue Dec 23 18:05:30 2014 -0800
Committer: Abraham Elmahrek <ab...@apache.org>
Committed: Tue Dec 23 18:05:30 2014 -0800

----------------------------------------------------------------------
 .../java/org/apache/sqoop/common/test/db/DerbyProvider.java | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/sqoop/blob/0cfeb198/common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java
----------------------------------------------------------------------
diff --git a/common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java b/common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java
index a25a300..98591a3 100644
--- a/common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java
+++ b/common-test/src/main/java/org/apache/sqoop/common/test/db/DerbyProvider.java
@@ -93,8 +93,9 @@ public class DerbyProvider extends DatabaseProvider {
       // Server successfully started at this point
       started = true;
     } catch (Exception e) {
-      LOG.error("Can't start Derby network server", e);
-      throw new RuntimeException("Can't derby server", e);
+      String message = "Can't start embedded Derby server";
+      LOG.fatal(message, e);
+      throw new RuntimeException(message, e);
     }
 
     super.start();
@@ -110,7 +111,9 @@ public class DerbyProvider extends DatabaseProvider {
         server.shutdown();
       }
     } catch (Exception e) {
-      LOG.info("Can't shut down embedded server", e);
+      String message = "Can't shut down embedded Derby server";
+      LOG.fatal(message, e);
+      throw new RuntimeException(message, e);
     }
   }