[GitHub] [incubator-superset] john-bodley edited a comment on pull request #10427: chore: Cleanup database sessions

[GitBox <gi...@apache.org>]

john-bodley edited a comment on pull request #10427:
URL: https://github.com/apache/incubator-superset/pull/10427#issuecomment-664016193


   Thanks @villebro. I've reverted some of my changes in `tests/celery_tests.py` which removed some `session.close()` statements. Per the [Session.close](https://docs.sqlalchemy.org/en/13/orm/session_api.html#sqlalchemy.orm.session.Session.close) documentation, 
   
   > This clears all items and ends any transaction in progress.
   
   which may be necessary as some of the Celery tasks first try to drop a table and may throw an exception if the table exists. Ending the transaction may be necessary prior to running the async query.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org