You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/28 14:29:09 UTC

[GitHub] [pulsar-client-go] PowerStateFailure edited a comment on pull request #474: Fix race condition/goroutine leak in partition discovery goroutine

PowerStateFailure edited a comment on pull request #474:
URL: https://github.com/apache/pulsar-client-go/pull/474#issuecomment-787461306


   @omnilight
   
   > Could you please fix failed build?
   
   As i can see from [build log](https://github.com/apache/pulsar-client-go/pull/474/checks?check_run_id=1954445477#step:4:2573), there is race condition somewhere in connection acquire logic. As I don't change it, i'm unsure if i should fix it.
   
   BTW, it seems that producer has [the same issue](https://github.com/apache/pulsar-client-go/blob/21541d6d40a6324db7b3952d9e1d392d872ce231/pulsar/producer_impl.go#L132) with closing background partition discovery goroutine, so I'll try to fix it too.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org