You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2025/10/15 14:35:50 UTC
[PR] Upgrade Mimir [maven]
cstamas opened a new pull request, #11274:
URL: https://github.com/apache/maven/pull/11274
And collect more information, and we seems loose some information in case of IT failures.
Changes:
* upgrade to Mimir 0.10.0
* GH action collects IT failsafe outputs as well (as I sus we have something on stdout or stderr)
* centrally manage Toolbox and Mimir versions
* make Maven 3 use Mimir as well (by doing UW or PW setup for it)
* in maven-executor and maven-cli test disable prefix handling for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Mimir [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #11274:
URL: https://github.com/apache/maven/pull/11274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Mimir [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #11274:
URL: https://github.com/apache/maven/pull/11274#discussion_r2435157964
##########
impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvn/resident/ResidentMavenInvokerTest.java:
##########
@@ -61,7 +61,7 @@ void defaultFs(
invoke(cwd, userHome, List.of("verify"), List.of());
}
- @Disabled("Until we move off fully from File")
+ @Disabled("Enable when core moves off fully from FS")
Review Comment:
The `FS` is ambiguous. We need to enable it when we fully move to the NIO2 api with Path/java.nio.file.Filesystem, rather than File/java.io.FileSystem, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Mimir [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #11274:
URL: https://github.com/apache/maven/pull/11274#discussion_r2435172523
##########
impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvn/resident/ResidentMavenInvokerTest.java:
##########
@@ -61,7 +61,7 @@ void defaultFs(
invoke(cwd, userHome, List.of("verify"), List.of());
}
- @Disabled("Until we move off fully from File")
+ @Disabled("Enable when core moves off fully from FS")
Review Comment:
Yes, let me reword this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade Mimir [maven]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #11274:
URL: https://github.com/apache/maven/pull/11274#discussion_r2435184344
##########
impl/maven-cli/src/test/java/org/apache/maven/cling/invoker/mvn/resident/ResidentMavenInvokerTest.java:
##########
@@ -61,7 +61,7 @@ void defaultFs(
invoke(cwd, userHome, List.of("verify"), List.of());
}
- @Disabled("Until we move off fully from File")
+ @Disabled("Enable when core moves off fully from FS")
Review Comment:
```
@Disabled("Enable it when fully moved to NIO2 with Path/Filesystem (ie MavenExecutionRequest)")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org