[GitHub] [beam] daria-malkova commented on a change in pull request #16121: [BEAM-13334][Playground] Save Go logs to the cache

[GitBox <gi...@apache.org>]

daria-malkova commented on a change in pull request #16121:
URL: https://github.com/apache/beam/pull/16121#discussion_r762031955



##########
File path: playground/backend/internal/code_processing/code_processing.go
##########
@@ -250,6 +308,55 @@ func cancelCheck(ctx context.Context, pipelineId uuid.UUID, cancelChannel chan b
 	}
 }
 
+// readLogFile reads logs from the log file and keeps it to the cache.
+// If context is done it means that the code processing was finished (successfully/with error/timeout). Write last logs to the cache.
+// If <-stopReadLogsChannel it means that the code processing was finished (canceled/timeout)
+// 	and it waits until the method stops the work to change status to the pb.Status_STATUS_FINISHED. Write last logs

Review comment:
       Why is there a tabulation necessary here? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org