You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "goiri (via GitHub)" <gi...@apache.org> on 2023/04/20 18:55:30 UTC

[GitHub] [hadoop] goiri commented on a diff in pull request #5545: HADOOP-18710. Add RPC metrics for response time

goiri commented on code in PR #5545:
URL: https://github.com/apache/hadoop/pull/5545#discussion_r1172974795


##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java:
##########
@@ -282,6 +290,15 @@ public void addRpcProcessingTime(long processingTime) {
     }
   }
 
+  public void addRpcResponseTime(long processingTime) {

Review Comment:
   Having the unit would help



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org