[GitHub] [spark] srowen commented on a change in pull request #28727: [SPARK-31879][SQL][test-java11] Preset monday start(iso) for the first day of week by reflection

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #28727:
URL: https://github.com/apache/spark/pull/28727#discussion_r435222713



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -155,7 +157,22 @@ trait DateTimeFormatterHelper {
   }
 }
 
-private object DateTimeFormatterHelper {
+private[spark] object DateTimeFormatterHelper {
+  val defaultLocale = Locale.US
+
+  def presetSundayStartToMondayStart(): Unit = {
+    val CACHE: Field = classOf[WeekFields].getDeclaredField("CACHE")

Review comment:
       Yikes, isn't this going to change the Locale's settings for the whole JVM?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org