You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Bukama (via GitHub)" <gi...@apache.org> on 2025/12/28 07:36:33 UTC
[PR] Build on Zulu and Temurin [maven-jmod-plugin]
Bukama opened a new pull request, #93:
URL: https://github.com/apache/maven-jmod-plugin/pull/93
Add another JDK to the matrix to check JEP 493 changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build on Zulu and Temurin [maven-jmod-plugin]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #93:
URL: https://github.com/apache/maven-jmod-plugin/pull/93#issuecomment-3694883349
Please avoid adding too many java flavors as this would be unnecessary multiplying no execution - for each java &Maven version. Let's be a bit more green to the environment and donated hardware resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build on Zulu and Temurin [maven-jmod-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #93:
URL: https://github.com/apache/maven-jmod-plugin/pull/93#issuecomment-3694801445
> We should also consider adding at least temurin 25 and maybe zulu to other projects' CI configs since there does seem to be the real possibility of code working on Oracle but not temurin.
zulu (by Microsoft and Azul, not Oracle) is the default JDK we built on (see https://github.com/apache/maven-gh-actions-shared/blob/417fdff72db17fcbafd5f8d2471360e9b39f4ae3/.github/workflows/maven-verify.yml#L44 ). There are a few projects (e.g. mnaven javadoc plugin or this PR) where we overwrite this to use other/additional JDK.
However it seems that Zulu JDK still ships with JMOD folder, even that they "support the concept of JEP 493" (https://docs.azul.com/core/release/july-2025/release-notes) as the build pipeline of the Maven JMod Plugin shows. Temurin JDK folks wrote that they follow the OpenJDK and removed the JMOD files, so they seem to be "closer" to the original/base Open JDK. So yes I agree we should add Temurin to general Mavens GHA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build on Zulu and Temurin [maven-jmod-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama closed pull request #93: Build on Zulu and Temurin
URL: https://github.com/apache/maven-jmod-plugin/pull/93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build on Zulu and Temurin [maven-jmod-plugin]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #93:
URL: https://github.com/apache/maven-jmod-plugin/pull/93#issuecomment-3694806541
> This is very helpful. Thanks. I do think we need to figure out how to fix this before merging.
ofc. That's why it's only a draft. I wanted to verify the different outcome of Temurin on GHA too (not only on my local machine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org