[jira] [Commented] (QPID-8657) [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17793279#comment-17793279 ] 

ASF GitHub Bot commented on QPID-8657:
--------------------------------------

dakirily opened a new pull request, #229:
URL: https://github.com/apache/qpid-broker-j/pull/229

   This PR addresses [QPID-8657](https://issues.apache.org/jira/browse/QPID-8657), fixing an issue with missing validation of ACL attributes




> [Broker-J] ACL - Posting unknown attributes leaves broker in bad internal state
> -------------------------------------------------------------------------------
>
>                 Key: QPID-8657
>                 URL: https://issues.apache.org/jira/browse/QPID-8657
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-9.0.0
>            Reporter: Kyrre
>            Priority: Minor
>         Attachments: aclRequest.json, qpidErrorLog.txt, resultingAcl.json
>
>
> When POSTing an ACL rule with unknown attributes to the Qpid HTTP management API, the server responds with HTTP 422, Unprocessable Entity. This is somewhat OK, however, I think maybe a 400 Bad Request would be more appropriate.
> But after the post, the broker is somehow left in a bad internal state, as the returned Json is incomplete and unparseable.
> Example POST in [^aclRequest.json]
> Qpid log from the incident [^qpidErrorLog.txt]
> Returned Json from subsequent GET [^resultingAcl.json]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org