You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ted-ross <gi...@git.apache.org> on 2017/12/20 18:37:34 UTC
[GitHub] qpid-dispatch pull request #237: DISPATCH-905 - Added a general get-as-strin...
GitHub user ted-ross opened a pull request:
https://github.com/apache/qpid-dispatch/pull/237
DISPATCH-905 - Added a general get-as-string facility for proton data…
… elements. Use this facility for the port field in the failover list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ted-ross/qpid-dispatch tross-DISPATCH-905
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/237.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #237
----
commit cb7f723a6555827d2f8719b101e5e8a5f3935d6f
Author: Ted Ross <tr...@...>
Date: 2017-12-20T18:16:54Z
DISPATCH-905 - Added a general get-as-string facility for proton data elements. Use this facility for the port field in the failover list.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #237: DISPATCH-905 - Added a general get-as-strin...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/237#discussion_r158114523
--- Diff: src/router_node.c ---
@@ -912,7 +913,7 @@ static void AMQP_opened_handler(qd_router_t *router, qd_connection_t *conn, bool
strcmp(sym.start, QD_CONNECTION_PROPERTY_FAILOVER_PORT_KEY) == 0) {
pn_data_next(props);
if (pn_data_type(props) == PN_STRING) {
--- End diff --
since qdpn_data_as_string returns anything as string, the if check is not required -
if (pn_data_type(props) == PN_STRING) {
}
should be removed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #237: DISPATCH-905 - Added a general get-as-strin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/237
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org