You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Ryan Williams (JIRA)" <ji...@apache.org> on 2019/03/01 05:52:00 UTC
[jira] [Updated] (BEAM-4775) JobService should support returning
metrics
[ https://issues.apache.org/jira/browse/BEAM-4775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Williams updated BEAM-4775:
--------------------------------
Description:
Design doc: [https://s.apache.org/get-metrics-api].
h1. Relevant PRs in flight:
h2. Approved / Ready to merge:
None atm.
h2. Ready for Review:
* [#7971|https://github.com/apache/beam/pull/7971]: Flink portable metrics: get ptransform from MonitoringInfo, not stage name
** this is a simpler, Flink-specific PR that is basically duplicated inside each of the following two, so may be worth trying to merge in first
* [#7934|https://github.com/apache/beam/pull/7934]: add GetJobMetrics RPC, Java+Python SDK support for it
* #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data model in Java SDK metrics
h2. Iterating / Discussing:
* [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
h2. Merged
* [#7867|https://github.com/apache/beam/pull/7867]: key MetricResult by a MetricKey
* [#7938|https://github.com/apache/beam/pull/7938]: move MonitoringInfo protos to model/pipeline module
* [#7883|https://github.com/apache/beam/pull/7883]: Add MetricQueryResults.allMetrics() helper
* [#7866|https://github.com/apache/beam/pull/7866]: move function helpers from fn-harness to sdks/java/core
* [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult implementations
h2. Closed
* [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos; support integer distributions, gauges
h1. Likely pieces still to come:
Per recent discussion with [~robertwb], I'm going to move the MonitoringInfo protos into the {{model/pipeline}} module, which the Job API, Fn API, and sdks/java/core all depend on already, as it's a good/central place for them.
h1. Previous Description:
[https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto] currently doesn't appear to have a way for JobService to return metrics to a user, even though [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto] includes support for reporting SDK metrics to the runner harness.
Metrics are apparently necessary to run any ValidatesRunner tests because PAssert needs to validate that the assertions succeeded. However, this statement should be double-checked: perhaps it's possible to somehow work with PAssert without metrics support.
was:
Design doc: [https://s.apache.org/get-metrics-api].
h1. Relevant PRs in flight:
h2. Approved / Ready to merge:
None atm.
h2. Ready for Review:
* [#7934|https://github.com/apache/beam/pull/7934]: add GetJobMetrics RPC, Java+Python SDK support for it
h2. Iterating / Discussing:
* [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
h2. Needs Updating
* #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data model in Java SDK metrics
h2. Merged
* [#7867|https://github.com/apache/beam/pull/7867]: key MetricResult by a MetricKey
* [#7938|https://github.com/apache/beam/pull/7938]: move MonitoringInfo protos to model/pipeline module
* [#7883|https://github.com/apache/beam/pull/7883]: Add MetricQueryResults.allMetrics() helper
* [#7866|https://github.com/apache/beam/pull/7866]: move function helpers from fn-harness to sdks/java/core
* [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult implementations
h2. Closed
* [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos; support integer distributions, gauges
h1. Likely pieces still to come:
Per recent discussion with [~robertwb], I'm going to move the MonitoringInfo protos into the {{model/pipeline}} module, which the Job API, Fn API, and sdks/java/core all depend on already, as it's a good/central place for them.
h1. Previous Description:
[https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto] currently doesn't appear to have a way for JobService to return metrics to a user, even though [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto] includes support for reporting SDK metrics to the runner harness.
Metrics are apparently necessary to run any ValidatesRunner tests because PAssert needs to validate that the assertions succeeded. However, this statement should be double-checked: perhaps it's possible to somehow work with PAssert without metrics support.
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Labels: triaged
> Time Spent: 32.5h
> Remaining Estimate: 0h
>
> Design doc: [https://s.apache.org/get-metrics-api].
> h1. Relevant PRs in flight:
> h2. Approved / Ready to merge:
> None atm.
> h2. Ready for Review:
> * [#7971|https://github.com/apache/beam/pull/7971]: Flink portable metrics: get ptransform from MonitoringInfo, not stage name
> ** this is a simpler, Flink-specific PR that is basically duplicated inside each of the following two, so may be worth trying to merge in first
> * [#7934|https://github.com/apache/beam/pull/7934]: add GetJobMetrics RPC, Java+Python SDK support for it
> * #[7915|https://github.com/apache/beam/pull/7915]: use MonitoringInfo data model in Java SDK metrics
> h2. Iterating / Discussing:
> * [#7868|https://github.com/apache/beam/pull/7868]: MonitoringInfo URN tweaks
> h2. Merged
> * [#7867|https://github.com/apache/beam/pull/7867]: key MetricResult by a MetricKey
> * [#7938|https://github.com/apache/beam/pull/7938]: move MonitoringInfo protos to model/pipeline module
> * [#7883|https://github.com/apache/beam/pull/7883]: Add MetricQueryResults.allMetrics() helper
> * [#7866|https://github.com/apache/beam/pull/7866]: move function helpers from fn-harness to sdks/java/core
> * [#7890|https://github.com/apache/beam/pull/7890]: consolidate MetricResult implementations
> h2. Closed
> * [#7876|https://github.com/apache/beam/pull/7876]: Clean up metric protos; support integer distributions, gauges
> h1. Likely pieces still to come:
> Per recent discussion with [~robertwb], I'm going to move the MonitoringInfo protos into the {{model/pipeline}} module, which the Job API, Fn API, and sdks/java/core all depend on already, as it's a good/central place for them.
> h1. Previous Description:
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto] currently doesn't appear to have a way for JobService to return metrics to a user, even though [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto] includes support for reporting SDK metrics to the runner harness.
> Metrics are apparently necessary to run any ValidatesRunner tests because PAssert needs to validate that the assertions succeeded. However, this statement should be double-checked: perhaps it's possible to somehow work with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)