You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/05/09 20:35:09 UTC

[Bug 122265] New: Help/About Box copyright statement still says 2012

https://issues.apache.org/ooo/show_bug.cgi?id=122265

            Bug ID: 122265
        Issue Type: DEFECT
           Summary: Help/About Box copyright statement still says 2012
    Classification: Code
           Product: General
           Version: AOO400-dev
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: blocker
          Priority: P3
         Component: ui
          Assignee: issues@openoffice.apache.org
          Reporter: robweir@apache.org
                CC: issues@openoffice.apache.org
             Flags: 4.0.0_release_blocker+

Help/About Box copyright statement still says 2012.  It should be updated to
2013.

Another idea would be to make it be determined at build time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #4 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #3)
> For us (french), we can change it.
> Should we to set it or not?

You have to wait for original en-US string to be updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|arielch@apache.org          |jsc@apache.org

--- Comment #13 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #12)
> @Ariel I hope I have not triggered duplicate work now, you can assign the
> issue to me to signal that I should continue. Sorry for potential confusion

Nop I was going to start tomorrow ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #5 from Ariel Constenla-Haile <ar...@apache.org> ---
Created attachment 80682
  --> https://issues.apache.org/ooo/attachment.cgi?id=80682&action=edit
ABOUT_STR_COPYRIGHT in all languages

The document contains the translation of ABOUT_STR_COPYRIGHT in all languages
as available on the AOO340 branch.

Spreadsheet "Released" contains only languages released in 3.4.1 (27 + en-US).

The question still open is weather to mark "Copyright © %YEAR%  Apache Software
Foundation." as a string that should not be translated at all.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #6 from Marcus <ma...@apache.org> ---
@jsc: I don't know why this shouldn't be allowed. Any reason(s) you think it's
maybe not that good? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |AOO 4.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #9 from Rob Weir <ro...@apache.org> ---
Possible issue with updating it at build time.  It is a date, but it is also
stating an owner.  The date should reflect the date of when the creative work
was made.  And the owner should reflect who made the creative content.

So suppose we publish AOO 4.0 in 2013.  It is correct that it says "Copyright
2013, The Apache Software Foundation".

But then suppose someone downloads the source code, and rebuilds it in 2014.  
Several scenarios:

1) They make no changes, but just rebuild it.  Since there is no creative
change, the copyright should remain 2013.  It is like when you just reprint a
book.  The copyright doesn't change.  But if you make a new edition, i.e.,
content changes, then you change the copyright.

2) What if a 3rd party does make changes?  The date can change, but the owner
does as well.  So it should say something like "Copyright Foobar Corporation
2014, portion copyright The Apache Software Foundation", or something like
that.

Note:  the copyright statement should not be translated.  This is per US
regulations:

http://www.copyright.gov/title37/202.html See: § 202.2 (a)(4)

Since the ASF is US-based we should follow those rules.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

edoardopanfili <ed...@aspix.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #17 from edoardopanfili <ed...@aspix.it> ---
Verified on OS X 10.8
AOO400m2(Build:9701)  -  Rev. 1496831
2013-06-25 15:52:47 (Tue, 25 Jun 2013)


and on Windows 8
AOO400m2(Build:9701)  -  Rev. 1489073
2013-06-03 13:48:37 (Mo, 03 Jun 2013)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #11 from jsc@apache.org ---
I can take the latest comment form Rob into account and can make the copyright
statement depending on OOOVENDOR as well

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #12 from jsc@apache.org ---
@Ariel I hope I have not triggered duplicate work now, you can assign the issue
to me to signal that I should continue. Sorry for potential confusion

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #2 from jsc@apache.org ---
updating at build time sounds good but I don't know if that is allowed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

fanyuzhen@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fanyuzhen@gmail.com
         QA Contact|                            |edoardo@aspix.it

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #14 from SVN Robot <sv...@dev.null.org> ---
"jsc" committed SVN revision 1484665 into trunk:
#122265# split resource string to get more flexibility and drop general
copyr...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #8 from Ariel Constenla-Haile <ar...@apache.org> ---
(In reply to comment #7)
> I would say we mark "Copyright © %YEAR%  Apache Software Foundation." as a
> string that should not be translated at all. Or even better we extract it
> from the resource and add it in the code directly.

Can the year be set at build time?
The only thing I can imagine right now, is setting a variable in set_soenv.in

my $build_year = (localtime)[5] + 1900;
ToFile( "BUILD_YEAR",        "$build_year", "e" );

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

oooforum <oo...@free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oooforum@free.fr

--- Comment #3 from oooforum <oo...@free.fr> ---
For us (french), we can change it.
Should we to set it or not?
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ACCEPTED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from jsc@apache.org ---
fixed

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Help/About Box copyright    |Update the year in the
                   |statement still says 2012   |About dialog

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |ACCEPTED
           Assignee|issues@openoffice.apache.or |arielch@apache.org
                   |g                           |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #7 from jsc@apache.org ---
I would say we mark "Copyright © %YEAR%  Apache Software Foundation." as a
string that should not be translated at all. Or even better we extract it from
the resource and add it in the code directly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Help/About Box copyright statement still says 2012

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

Ariel Constenla-Haile <ar...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arielch@apache.org,
                   |                            |jsc@apache.org

--- Comment #1 from Ariel Constenla-Haile <ar...@apache.org> ---
Adding Jürgen on CC

@jsc: this will trigger a translation update because the string is marked as
translatable; beside, there have been other suggestions about modifying the
string contents on the mailing list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #10 from jsc@apache.org ---
@Ariel, I am already working on it...

I currently set a define i the makefile -> date -"%Y" and use it in the source.
I split the string in several parts.

1. "Copyright © 2013 Apache Software Foundation.
All rights reserved."

not translated and the year is set based on the define or if no define to 2013
to ensure a date

2. depending OOOVENDOR
2.1 if OOVENDOR is not Apache Software Foundation

"This product was created by %OOOVENDOR, based on Apache OpenOffice."

2.2.

"This product was created by the OpenOffice community."

3. "The OpenOffice commnity acknowledges all contributing members, especially
those mentioned at"

My plan was to prepare screen shots with both and go back on the mailing list.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug 122265] Update the year in the About dialog

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=122265

--- Comment #16 from jsc@apache.org ---
I have split the string to get more flexibility. The general copyright
statement is removed from the translation and will be set in dependency of the
OOOVENDOR variable. If the vendor is not the ASF, we add a portion copyright
statement to the ASF additionally.

I change the translation string also to use some other wording. A little bit
more space between the section is also used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.