You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Jake Maes <ja...@gmail.com> on 2016/08/19 00:28:24 UTC

Review Request 51228: SAMZA-1000 Update readme for hello-samza with a local build

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51228/
-----------------------------------------------------------

Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).


Bugs: SAMZA-1000
    https://issues.apache.org/jira/browse/SAMZA-1000


Repository: samza-hello-samza


Description
-------

SAMZA-1000 Update readme for hello-samza with a local build


Diffs
-----

  README.md 439000664cff0cf913abd72541c5714e6bcff6fb 

Diff: https://reviews.apache.org/r/51228/diff/


Testing
-------


Thanks,

Jake Maes


Re: Review Request 51228: SAMZA-1000 Update readme for hello-samza with a local build

Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51228/#review146397
-----------------------------------------------------------


Fix it, then Ship it!




lgtm!


README.md (line 8)
<https://reviews.apache.org/r/51228/#comment212807>

    Please remember to merge this section (from line 8 to 31) to latest branch in hello-samza repo as well.



README.md (line 11)
<https://reviews.apache.org/r/51228/#comment212802>

    nit: trailing whitespaces.


- Yi Pan (Data Infrastructure)


On Aug. 19, 2016, 12:28 a.m., Jake Maes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51228/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2016, 12:28 a.m.)
> 
> 
> Review request for samza, Boris Shkolnik, Chris Pettitt, Fred Ji, Jake Maes, Navina Ramesh, Jagadish Venkatraman, Xinyu Liu, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-1000
>     https://issues.apache.org/jira/browse/SAMZA-1000
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> SAMZA-1000 Update readme for hello-samza with a local build
> 
> 
> Diffs
> -----
> 
>   README.md 439000664cff0cf913abd72541c5714e6bcff6fb 
> 
> Diff: https://reviews.apache.org/r/51228/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jake Maes
> 
>