You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/10/08 01:15:59 UTC

[GitHub] [arrow] kou commented on a change in pull request #11337: ARROW-9843: [C++] WIP Implement Between trinary kernel

kou commented on a change in pull request #11337:
URL: https://github.com/apache/arrow/pull/11337#discussion_r724632008



##########
File path: cpp/src/arrow/compute/kernels/scalar_between.cc
##########
@@ -0,0 +1,152 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       How about putting this to existing `scalar_compare.cc`? It will reduce build time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org